[MRG+1] DOC Simplifying margin plotting in SVM examples (#8501) #8875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vene
reviewed
Jun 5, 2017
examples/svm/plot_custom_kernel.py
Outdated
|
|
||
|
|
||
| def my_kernel(X, Y): | ||
| def my_kernel(X, y): |
There was a problem hiding this comment.
The y here is not the same as the y on line 20. This one should remain capitalized Y, like the kernels in the pairwise module.
There was a problem hiding this comment.
In particular, I might suggest reverting all changes to this file since it does not contribute toward the goal of this PR.
There was a problem hiding this comment.
I have made similar changes to the following:
- examples/svm/plot_svm_nonlinear.py
- examples/svm/plot_svm_margin.py
- examples/svm/plot_svm_kernels.py
Do you want me to revert these as well?
I only did this for the sake of consistency with the additions I made.
|
I would suggest taking out the changes which consist only of switching y and Y, as I wrote inline as well. In the remaining two examples (plot_separating_hyperplane.py and plot_separating_hyperplane_unbalanced.py) I like the refactored code, with the observation that you should add back the call to
I like the new |
|
I would suggest so. In any case, pairwise kernels are between (X, Y), not
between (X, y): the meaning of the variables is not the same as in fit.
…On Tue, Jun 6, 2017 at 6:58 AM, Vathsala Achar ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/svm/plot_custom_kernel.py
<#8875 (comment)>
:
>
-def my_kernel(X, Y):
+def my_kernel(X, y):
I have made similar changes to the following:
- examples/svm/plot_svm_nonlinear.py
- examples/svm/plot_svm_margin.py
- examples/svm/plot_svm_kernels.py
Do you want me to revert these as well?
I only did this for the sake of consistency with the additions I made.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8875 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOwUdcPuk-b_AV9plTjr2FoxGoEkoGmks5sBHoAgaJpZM4NaKY5>
.
|
|
Okay, thank you very much for the review. I'll get back to you with the changes soon. Also, how does this look for the I can get them to cluster tighter if you like. |
|
Strictly aesthetically I think that the old plot here was much clearer, I find the wide margin and near-vertical angle confusing here. I would not spend too much time getting it to look exactly like that, but if you could get the clusters more rotated towards the corners easily by just changing the random seed or something, it'd be great. |
VathsalaAchar
force-pushed
the
svm_margin_plotting
branch
2 times, most recently
from
d8d9358 to
587f11a
Compare
* updated to use contour levels on decision function * separating unbalanced class now uses a red line to show the change in the decision boundary when the classes are weighted * corrected the target variable from Y to y
* Fixing flake8 issues * Altered make_blobs to move clusters to corners and be more compact * Reverted changes converting Y to y
VathsalaAchar
force-pushed
the
svm_margin_plotting
branch
from
5d24bae to
11db8aa
Compare
|
@vene I made the changes, how does this look? |
|
This LGTM |
jnothman
changed the title
jnothman
changed the title
|
LGTM as well... and maybe, one day, we'll get a helper to create the mesh... |
This was referenced Aug 1, 2017
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 6, 2017
…#8501) (scikit-learn#8875) * Simplifying margin plotting in SVM examples (scikit-learn#8501) * updated to use contour levels on decision function * separating unbalanced class now uses a red line to show the change in the decision boundary when the classes are weighted * corrected the target variable from Y to y * DOC Updates to SVM examples * Fixing flake8 issues * Altered make_blobs to move clusters to corners and be more compact * Reverted changes converting Y to y * Fixes for flake8 errors
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…#8501) (scikit-learn#8875) * Simplifying margin plotting in SVM examples (scikit-learn#8501) * updated to use contour levels on decision function * separating unbalanced class now uses a red line to show the change in the decision boundary when the classes are weighted * corrected the target variable from Y to y * DOC Updates to SVM examples * Fixing flake8 issues * Altered make_blobs to move clusters to corners and be more compact * Reverted changes converting Y to y * Fixes for flake8 errors
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…#8501) (scikit-learn#8875) * Simplifying margin plotting in SVM examples (scikit-learn#8501) * updated to use contour levels on decision function * separating unbalanced class now uses a red line to show the change in the decision boundary when the classes are weighted * corrected the target variable from Y to y * DOC Updates to SVM examples * Fixing flake8 issues * Altered make_blobs to move clusters to corners and be more compact * Reverted changes converting Y to y * Fixes for flake8 errors
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…#8501) (scikit-learn#8875) * Simplifying margin plotting in SVM examples (scikit-learn#8501) * updated to use contour levels on decision function * separating unbalanced class now uses a red line to show the change in the decision boundary when the classes are weighted * corrected the target variable from Y to y * DOC Updates to SVM examples * Fixing flake8 issues * Altered make_blobs to move clusters to corners and be more compact * Reverted changes converting Y to y * Fixes for flake8 errors
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…#8501) (scikit-learn#8875) * Simplifying margin plotting in SVM examples (scikit-learn#8501) * updated to use contour levels on decision function * separating unbalanced class now uses a red line to show the change in the decision boundary when the classes are weighted * corrected the target variable from Y to y * DOC Updates to SVM examples * Fixing flake8 issues * Altered make_blobs to move clusters to corners and be more compact * Reverted changes converting Y to y * Fixes for flake8 errors
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…#8501) (scikit-learn#8875) * Simplifying margin plotting in SVM examples (scikit-learn#8501) * updated to use contour levels on decision function * separating unbalanced class now uses a red line to show the change in the decision boundary when the classes are weighted * corrected the target variable from Y to y * DOC Updates to SVM examples * Fixing flake8 issues * Altered make_blobs to move clusters to corners and be more compact * Reverted changes converting Y to y * Fixes for flake8 errors
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…#8501) (scikit-learn#8875) * Simplifying margin plotting in SVM examples (scikit-learn#8501) * updated to use contour levels on decision function * separating unbalanced class now uses a red line to show the change in the decision boundary when the classes are weighted * corrected the target variable from Y to y * DOC Updates to SVM examples * Fixing flake8 issues * Altered make_blobs to move clusters to corners and be more compact * Reverted changes converting Y to y * Fixes for flake8 errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for Issue #8501
updated to use contour levels on decision function
the unbalanced class (in plot_separating_hyperplane_unbalanced.py) now uses a red line to show the change in the decision boundary when the classes are weighted
corrected the target variable from Y to y in other svm examples