Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] Fixes #8198 - error in datasets.make_moons #8199

Merged
merged 8 commits into from
Jan 17, 2017
Merged

[MRG+1] Fixes #8198 - error in datasets.make_moons #8199

merged 8 commits into from
Jan 17, 2017

Conversation

levy5674
Copy link
Contributor

@levy5674 levy5674 commented Jan 14, 2017 •
edited
Loading

Reference Issue

Fixes #8198

What does this implement/fix? Explain your changes.

Inside make_moons, n_samples_out elements go into outer_circle_x and outer_circle_y but n_samples_in elements of y get set to 1

Any other comments?

%pylab inline
from sklearn.datasets import make_moons

XL, YL = make_moons(5)
XU, YU = make_moons(495)
scatter(XL[:,0], XL[:,1], c=YL, s=200)
scatter(XU[:,0], XU[:,1], c=YU)

Before:
sklearn_8198_broken

After
sklearn_8198_fixed

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Jan 14, 2017 via email

@jnothman
Copy link
Member

LGTM. Please add a bug fix entry to whats_new.rst

@jnothman jnothman changed the title [MRG] Fixes #8198 - error in datasets.make_moons [MRG+1] Fixes #8198 - error in datasets.make_moons Jan 15, 2017
@levy5674
Copy link
Contributor Author

I believe the circleci failures are related to #8209 and will go away when #7986 is merged.

@jnothman jnothman merged commit aea6462 into scikit-learn:master Jan 17, 2017
@jnothman
Copy link
Member

Thanks @levy5674

raghavrv pushed a commit to raghavrv/scikit-learn that referenced this pull request Jan 18, 2017
@levy5674 @raghavrv
[MRG+1] Fixes scikit-learn#8198 - error in datasets.make_moons (sciki…
74e2665 
…t-learn#8199)
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@levy5674 @sergeyf
[MRG+1] Fixes scikit-learn#8198 - error in datasets.make_moons (sciki…
c43f5a7 
…t-learn#8199)
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@levy5674 @Sundrique
[MRG+1] Fixes scikit-learn#8198 - error in datasets.make_moons (sciki…
2fe6b83 
…t-learn#8199)
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@levy5674 @NelleV
[MRG+1] Fixes scikit-learn#8198 - error in datasets.make_moons (sciki…
af5c1b3 
…t-learn#8199)
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@levy5674 @paulha
[MRG+1] Fixes scikit-learn#8198 - error in datasets.make_moons (sciki…
69c646a 
…t-learn#8199)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@levy5674 @maskani-moh
[MRG+1] Fixes scikit-learn#8198 - error in datasets.make_moons (sciki…
d38f3d9 
…t-learn#8199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datasets.make_moons returns incorrect label when n_samples is odd
3 participants
@levy5674 @GaelVaroquaux @jnothman