CI Add Windows free-threaded wheel #30313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
changed the title
|
This seems to work fine, I think this is ready to review. |
glemaitre
approved these changes
Nov 20, 2024
ogrisel
approved these changes
Nov 23, 2024
|
I checked that the tests are actually run in the free-threading version of Python here: |
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
added
the
To backport
lesteve
added
the
free-threading
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 4, 2024
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jeremiedbb
pushed a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
virchan
pushed a commit
to virchan/scikit-learn
that referenced
this pull request
Dec 9, 2024
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like scipy has a free-threaded wheel in scientific-python-nightly-wheel.
As noted in #28978 (comment) the fact that we use a Windows docker image in our setup is a bit cumbersome but I am trying the easiest thing for now which is to not use a Docker image for the free-threaded build.
The alternative would be to write some powershell to install free-threaded CPython in the minimal Docker image but it seems a bit too much work for what it is worth. I would guess this is not that likely that a missing DLL would happen for free-threaded and not vanilla CPython.
Context: the reason we have this custom Docker image on Windows is to avoid missing DLLs, see #15899, #18802 and #24612 (comment).