Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Exported WeightingStrategy for *_classmode reductions #27030

Merged
merged 2 commits into from
Aug 8, 2023
Merged

MNT Exported WeightingStrategy for *_classmode reductions #27030

merged 2 commits into from
Aug 8, 2023

Conversation

Micky774
Copy link
Contributor

@Micky774 Micky774 commented Aug 7, 2023

Reference Issues/PRs

As mentioned here in #26828

What does this implement/fix? Explain your changes.

Allows for the cimport of WeightingStrategy primarily for use in #26828

Any other comments?

@Micky774 Micky774 changed the title Exported WeightingStrategy for *_classmode reductions MNT Exported WeightingStrategy for *_classmode reductions Aug 7, 2023
@Micky774 Micky774 added Quick Review For PRs that are quick to review and removed module:metrics cython labels Aug 7, 2023
@Micky774 Micky774 mentioned this pull request Aug 7, 2023
Merged
@github-actions
Copy link

github-actions bot commented Aug 7, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5413343. Link to the linter CI: here

jjerphan
jjerphan approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

OmarManzoor
OmarManzoor approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Micky774

@OmarManzoor OmarManzoor merged commit 392c084 into scikit-learn:main Aug 8, 2023
@Micky774 Micky774 deleted the export_enum branch August 8, 2023 13:22
TamaraAtanasoska pushed a commit to TamaraAtanasoska/scikit-learn that referenced this pull request Aug 21, 2023
@Micky774 @TamaraAtanasoska
MNT Exported WeightingStrategy for *_classmode reductions (scikit…
d1a9141 
…-learn#27030)
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@Micky774 @REDVM
MNT Exported WeightingStrategy for *_classmode reductions (scikit…
646f661 
…-learn#27030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarManzoor OmarManzoor OmarManzoor approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
cython module:metrics Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Micky774 @jjerphan @OmarManzoor