Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Ensures that OrthogonalMatchingPursuitCV passes numpydoc validation #21412

Merged

Conversation

spikebh
Copy link
Contributor

@spikebh spikebh commented Oct 22, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures that OrthogonalMatchingPursuitCV estimator passes all numpydoc validation checks.

  • Remove OrthogonalMatchingPursuitCV from DOCSTRING_IGNORE_LIST.

  • Fixes on OrthogonalMatchingPursuitCV class docstring :

    • Some grammar fixes.
    • Sections order rearranged.
    • Missing descriptions for some references added.
    • Minor grammar fixes on fit method docstring.

@glemaitre
Copy link
Member

Thanks @spikebh LGTM

@glemaitre glemaitre added this to the 1.0.1 milestone Oct 23, 2021
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants