Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC ensures MultiTaskLasso passes numpydoc validation #21363

Merged
merged 1 commit into from
Oct 20, 2021
Merged

DOC ensures MultiTaskLasso passes numpydoc validation #21363

merged 1 commit into from
Oct 20, 2021

Conversation

felixglush
Copy link
Contributor

Reference Issues/PRs

Addresses #20308.

What does this implement/fix? Explain your changes.

  • Added return value description to MultitaskLasso.fit(self, X, y)
  • Added descriptions to MultitaskLasso's "See Also" section (Lasso and MultiTaskElasticNet)
  • Reordered sections to match required order: Parameters, Attributes, See Also, Notes, Examples
  • Added a period (.) to parameter "selection" description and to the "See Also: MultiTaskLasso" reference

Any other comments?

@glemaitre glemaitre merged commit 8762133 into scikit-learn:main Oct 20, 2021
@glemaitre
Copy link
Member

Thanks @felixglush LGTM.

@glemaitre glemaitre mentioned this pull request Oct 23, 2021
Merged
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
@felixglush @glemaitre
DOC ensures MultiTaskLasso passes numpydoc validation (scikit-learn#2…
a734af1 
…1363)
glemaitre pushed a commit that referenced this pull request Oct 25, 2021
@felixglush @glemaitre
DOC ensures MultiTaskLasso passes numpydoc validation (#21363)
7d74e93
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@felixglush @samronsin
DOC ensures MultiTaskLasso passes numpydoc validation (scikit-learn#2…
06a3c64 
…1363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixglush @glemaitre