Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Ensures that RandomForestClassifier passes numpydoc validation #20383

Merged
merged 10 commits into from
Jul 7, 2021
Merged

DOC Ensures that RandomForestClassifier passes numpydoc validation #20383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3c77276
Remove RandomForestClassifier from DOCSTRING_IGNORE_LIST
alinealfa Jun 26, 2021
f8026ad
Fix numpydoc errors RT03, GL08, SA04, GL02, GL03 on RandomForestClass…
alinealfa Jun 26, 2021
d3b3408
force decorate property to update doc for deprecated method
alinealfa Jun 26, 2021
5d710cf
implement suggested changes
alinealfa Jun 26, 2021
053193e
Merge remote-tracking branch 'upstream/main' into randomforestclassif…
alinealfa Jun 26, 2021
6c26a2c
add extra line for flake8
alinealfa Jun 26, 2021
f90833c
modify property docstring
glemaitre Jul 6, 2021
93389ce
Merge remote-tracking branch 'origin/main' into pr/alinealfa/20383
glemaitre Jul 6, 2021
198a321
Apply suggestions from code review
glemaitre Jul 7, 2021
c86901d
Merge remote-tracking branch 'origin/main' into pr/alinealfa/20383
glemaitre Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion maint_tools/test_docstrings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@
"RadiusNeighborsClassifier",
"RadiusNeighborsRegressor",
"RadiusNeighborsTransformer",
"RandomForestClassifier",
"RandomTreesEmbedding",
"RandomizedSearchCV",
"RegressorChain",
Expand Down
12 changes: 4 additions & 8 deletions sklearn/ensemble/_forest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,13 +613,7 @@ def feature_importances_(self):
)
@property
def n_features_(self):
"""Number of features when fitting the estimator.

Returns
-------
n_features_in_ : int
The number of features when fitting the estimator.
"""
"""Number of features when fitting the estimator."""
return self.n_features_in_


Expand Down Expand Up @@ -1293,7 +1287,9 @@ class labels (multi-output problem).

See Also
--------
DecisionTreeClassifier, ExtraTreesClassifier
sklearn.tree.DecisionTreeClassifier : A decision tree classifier.
sklearn.ensemble.ExtraTreesClassifier : Ensemble of extremely randomized
tree classifiers.

Notes
-----
Expand Down