Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy loading to skimage.segmentation #7035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ana42742
Copy link
Contributor

Description

Resolves a task in #6964.

Checklist

disk_level_set,
checkerboard_level_set
)
from ..morphology import flood, flood_fill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is reaching into a parallel submodule to the current one. Which is not supported by lazy_loader currently, see scientific-python/lazy-loader#52. Until it is, we need a workaround.

I would suggest moving this import into skimage/segmentation/_watershed.py (seems thematically close) and add a comment for context. Then update the appropriate import in this file to

from ._watershed import watershed, flood, flood_fill

Does that explanation make sense to you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @ana42742,

Are you able to address this review comment?

Thanks!

@lagru
Copy link
Member

lagru commented Jul 11, 2023

Would also be good if you could merge the recent changes from main into this PR branch.

This comment was marked as outdated.

@github-actions github-actions bot added the 😴 Dormant No recent activity label Mar 11, 2024
@github-actions github-actions bot removed the 😴 Dormant No recent activity label Apr 5, 2024
@lagru
Copy link
Member

lagru commented Sep 24, 2024

I'm confused why the bot removed the dormant label again?!

Anyway, @ana42742, do you want to pick this up? Otherwise, I'll assume that we can take over the next time I'm reminded of this.

@lagru lagru added the ⚽ Contributor's ball Waiting for action from the contributor label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 type: Performance ⚽ Contributor's ball Waiting for action from the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants