Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add contextlib support to pyhf.schema API #1818

Merged
merged 14 commits into from
Mar 23, 2022
Merged

feat: Add contextlib support to pyhf.schema API #1818

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
feb5176
add test
kratsg Mar 23, 2022
3dd0d7e
make sure test covers itself with teardown nicely
kratsg Mar 23, 2022
145cc94
make sure all tests cleared up
kratsg Mar 23, 2022
50c8d4d
add functionality
kratsg Mar 23, 2022
c096cba
need it in doctest block?
kratsg Mar 23, 2022
f5e9015
need it in doctest block?
kratsg Mar 23, 2022
8067dca
drop doctest
kratsg Mar 23, 2022
f340268
typo
kratsg Mar 23, 2022
2d400b8
add test to cover public api
kratsg Mar 23, 2022
ecb3669
1/0 is silly
kratsg Mar 23, 2022
f42ae42
Merge branch 'master' into feat/schemaContextLib
kratsg Mar 23, 2022
fdc01fc
Merge branch 'master' into feat/schemaContextLib
kratsg Mar 23, 2022
2f17722
Update src/pyhf/schema/__init__.py
kratsg Mar 23, 2022
d111ca7
feickert comments
kratsg Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add test
  • Loading branch information
@kratsg
kratsg committed Mar 23, 2022
commit feb51761ee2c3342e62125628c6f61500650483e
14 changes: 11 additions & 3 deletions tests/test_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,20 @@ def test_schema_changeable(datadir):
pyhf.Workspace(json.load(open(datadir / 'customschema' / 'custom.json')))

old_path = pyhf.schema.path
pyhf.schema(datadir / 'customschema')
new_path = datadir / 'customschema'
pyhf.schema(new_path)
assert pyhf.schema.path != old_path
assert pyhf.schema.path == datadir / 'customschema'
assert pyhf.Workspace(json.load(open(datadir / 'customschema' / 'custom.json')))
assert pyhf.schema.path == new_path
assert pyhf.Workspace(json.load(open(new_path / 'custom.json')))
pyhf.schema(old_path)

assert pyhf.schema.path == old_path
with pyhf.schema(new_path):
assert pyhf.schema.path != old_path
assert pyhf.schema.path == new_path
assert pyhf.Workspace(json.load(open(new_path / 'custom.json')))
assert pyhf.schema.path == old_path


def test_no_channels():
spec = {'channels': []}
Expand Down