Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema API lost changes #1822

Closed
1 task done
kratsg opened this issue Mar 24, 2022 · 1 comment
Closed
1 task done

Schema API lost changes #1822

kratsg opened this issue Mar 24, 2022 · 1 comment
Assignees
@kratsg
Labels
bug Something isn't working needs-triage Needs a maintainer to categorize and assign wontfix This will not be worked on

Comments

@kratsg
Copy link
Contributor

kratsg commented Mar 24, 2022

Summary

Not sure what happened. #1753 introduced a regression breaking the schema API. Need to provide a quick fix to get the versioning back... but the tests should've failed at that point, so not sure why they didn't.

pyhf.utils.validate(schema, version) -> pyhf.schema.validate(schema)

OS / Environment

n/a

Steps to Reproduce

Just look at the code

File Upload (optional)

No response

Expected Results

expect right API

Actual Results

see wrong API

pyhf Version

master

Code of Conduct

  • I agree to follow the Code of Conduct
@kratsg kratsg added bug Something isn't working needs-triage Needs a maintainer to categorize and assign labels Mar 24, 2022
@kratsg
Copy link
Contributor Author

kratsg commented Mar 24, 2022

never mind. wrong commit.

@kratsg kratsg closed this as completed Mar 24, 2022
@kratsg kratsg added the wontfix This will not be worked on label Mar 24, 2022
@kratsg kratsg self-assigned this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kratsg kratsg

Labels
bug Something isn't working needs-triage Needs a maintainer to categorize and assign wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kratsg