Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to cover oldest and newest Python #1816

Closed
matthewfeickert opened this issue Mar 23, 2022 · 1 comment · Fixed by #1817
Closed

Try to cover oldest and newest Python #1816

matthewfeickert opened this issue Mar 23, 2022 · 1 comment · Fixed by #1817
Labels
tests pytest

Comments

@matthewfeickert
Copy link
Member

In a follow up PR we should see if it would be worth making this

pyhf/.github/workflows/ci.yml

Line 70 in 1884c6c

if: github.event_name != 'schedule' && matrix.python-version == '3.10' && matrix.os == 'ubuntu-latest'

be for both the oldest and newest Python supported (so Python 3.7 and Python 3.10) so that we cover these sorts of things in our reports.

Originally posted by @matthewfeickert in #1753 (comment)
@matthewfeickert matthewfeickert added the tests pytest label Mar 23, 2022
This was referenced Mar 23, 2022
Merged
Merged
@kratsg
Copy link
Contributor

kratsg commented Mar 23, 2022

Consider using flags to add -F python3.7 or -F python3.10 so we can track where coverage comes from: https://docs.codecov.com/docs/flags ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests pytest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Report coverage for oldest and newest Python tested scikit-hep/pyhf
2 participants
@kratsg @matthewfeickert