Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure doctests are not providing sole coverage for any code #1653

Open
1 task done
matthewfeickert opened this issue Oct 19, 2021 · 0 comments
Open
1 task done

Ensure doctests are not providing sole coverage for any code #1653

matthewfeickert opened this issue Oct 19, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed / contributions welcome tests pytest

Comments

@matthewfeickert
Copy link
Member

Summary

PR #1467 showed that the doctests are currently providing coverage to some areas of the codebase that the tests themselves never reach (e.g., when moving the doctests to their own report, the coverage from running the tests dipped)

coverage

This isn't really good and the only thing that the doctests should be providing is testing of the docstring examples. We should add coverage of the codebase that is now provided by the doctests into the main tests.

Additional Information

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@matthewfeickert matthewfeickert added help wanted Extra attention is needed / contributions welcome good first issue Good for newcomers tests pytest labels Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed / contributions welcome tests pytest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthewfeickert