-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
salt: Use csc framework for UI configuration #3181
Merged
bert-e
merged 6 commits into
development/2.9
from
improvement/use-csc-framework-for-ui-configuration
Mar 22, 2021
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d935de9
salt: Use csc framework to configure UI deployment path
JBWatenbergScality aed95a4
salt: Use csc framework to configure UI theme
JBWatenbergScality 4cb5f22
salt: Use csc framework to configure shell UI
JBWatenbergScality ded4746
salt: Reference ui configuration in service configuration in order to…
JBWatenbergScality bc98afc
salt: Fix Shell UI tragets
JBWatenbergScality dc7625a
test: Add support for .in templates in salt formulas tests
JBWatenbergScality File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
salt: Use csc framework to configure UI deployment path
Refs: #3175
- Loading branch information
commit d935de93dcb1fa082f75171c6f6a49c4db783273
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
#!yaml | ||
|
||
# Defaults for configuration of MetalK8s UI | ||
apiVersion: addons.metalk8s.scality.com/v1alpha1 | ||
kind: UIConfig | ||
spec: | ||
basePath: / |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
include: | ||
- .namespace | ||
- .dependencies | ||
- .ui-configuration | ||
- .ui | ||
- .ingress |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
include: | ||
- .namespace | ||
|
||
{%- set metalk8s_ui_config = salt.metalk8s_kubernetes.get_object( | ||
kind='ConfigMap', | ||
apiVersion='v1', | ||
namespace='metalk8s-ui', | ||
name='metalk8s-ui-config', | ||
) | ||
%} | ||
|
||
{%- if metalk8s_ui_config is none %} | ||
|
||
Create metalk8s-ui-config ConfigMap: | ||
metalk8s_kubernetes.object_present: | ||
- manifest: | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: metalk8s-ui-config | ||
namespace: metalk8s-ui | ||
data: | ||
config.yaml: |- | ||
apiVersion: addons.metalk8s.scality.com/v1alpha1 | ||
kind: UIConfig | ||
spec: {} | ||
|
||
{%- else %} | ||
|
||
metalk8s-ui-config ConfigMap already exist: | ||
test.succeed_without_changes: [] | ||
|
||
{%- endif %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not "critical" but still a bit ugly 😜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took care of it in #3196