Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce salt Python linting #3066

Merged
merged 63 commits into from
Feb 8, 2021
Merged

Enforce salt Python linting #3066

Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
e146d30
salt-lint: cri module fix "useless-else-on-loop"
TeddyAndrieux Jan 25, 2021
ef6b534
salt-lint: metalk8s_cordon module fix "too-many-blank-lines"
TeddyAndrieux Jan 25, 2021
f8fdec1
salt-lint: metalk8s_drain module fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
a774ecd
salt-lint: metalk8s_drain module fix "unecessary-pass"
TeddyAndrieux Jan 25, 2021
7c64295
salt-lint: metalk8s_drain module fix "unused-variable"
TeddyAndrieux Feb 5, 2021
c1c4509
salt-lint: metalk8s_etcd module fix "blacklisted-module"
TeddyAndrieux Jan 25, 2021
772e5c9
salt-lint: metalk8s_etcd module fix "bare-except"
TeddyAndrieux Jan 25, 2021
bfb33b8
salt-lint: metalk8s_kubeconfig fix "broad-except"
TeddyAndrieux Jan 25, 2021
8af73f1
salt-lint: metalk8s_kubeconfig fix "resource-leakage"
TeddyAndrieux Jan 25, 2021
f6312b4
salt-lint: metalk8s_kubernetes module fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
111e620
salt-lint: metalk8s_kubernetes_utils module fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
a13f3c3
salt-lint: metalk8s_monitoring module fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
2b4d9a1
salt-lint: metalk8s_package_manager_yum fix "unused-import"
TeddyAndrieux Jan 25, 2021
a014224
salt-lint: metalk8s_package_manager_yum module fix "str-format-in-log"
TeddyAndrieux Feb 5, 2021
bfe486d
salt-lint: metalk8s module fix "blacklisted-module"
TeddyAndrieux Jan 25, 2021
53301a7
salt-lint: metalk8s module fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
45887c6
salt-lint: metalk8s module fix "resource-leakage"
TeddyAndrieux Jan 25, 2021
72b91ea
salt-lint: metalk8s module fix "unused-variable"
TeddyAndrieux Feb 5, 2021
7bee2f0
salt-lint: metalk8s module fix "str-format-in-logging"
TeddyAndrieux Feb 5, 2021
2fe35fd
salt-lint: metalk8s_service_configuration fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
378cc54
salt-lint: metalk8s_service_configuration module fix "unused-argument"
TeddyAndrieux Feb 5, 2021
3291a9f
salt-lint: metalk8s_solutions_k8s module fix "unused-import"
TeddyAndrieux Jan 25, 2021
fab98f3
salt-lint: metalk8s_solutions module fix "resource-leakage"
TeddyAndrieux Jan 25, 2021
1d94ff4
salt-lint: metalk8s_solutions module fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
60b8b92
salt-lint: metalk8s_sysctl module fix "unused-import"
TeddyAndrieux Jan 25, 2021
4a0746d
salt-lint: metalk8s_sysctl module fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
d523d7a
salt-lint: metalk8s_sysctl module fix "resource-leakage"
TeddyAndrieux Jan 25, 2021
16d8116
salt-lint: metalk8s_volumes module "2 spaces before inline comment"
TeddyAndrieux Jan 25, 2021
c9c0305
salt-lint: metalk8s_volumes module fix "2-blank-lines"
TeddyAndrieux Jan 25, 2021
0c639e7
salt-lint: metalk8s_volumes module fix "backslash-is-redundant-"
TeddyAndrieux Jan 25, 2021
1fb25e4
salt-lint: metalk8s_volumes module fix "blacklisted-module"
TeddyAndrieux Jan 25, 2021
bf7abcd
salt-lint: metalk8s_volumes module fix "unused-import"
TeddyAndrieux Jan 25, 2021
ad7a321
salt-lint: metalk8s_volumes module fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
20ec131
salt-lint: metalk8s_volumes module fix "str-format-in-logging"
TeddyAndrieux Feb 5, 2021
abff661
salt-lint: containerd state fix "too-many-blank-lines"
TeddyAndrieux Jan 25, 2021
de5402e
salt-lint: kubeconfig state fix "unused-argument"
TeddyAndrieux Feb 5, 2021
f1e2740
salt-lint: metalk8s_kubernetes state fix "unused-import"
TeddyAndrieux Jan 25, 2021
1ff9857
salt-lint: metalk8s state fix "undefined-variable"
TeddyAndrieux Jan 25, 2021
c81365e
salt-lint: metalk8s_volumes state fix "broad-except"
TeddyAndrieux Jan 25, 2021
5526f7c
salt-lint: metalk8s_volumes state fix "unused-import"
TeddyAndrieux Jan 25, 2021
3c71df6
salt-lint: kubernetes_utils utils fix "arguments-differ"
TeddyAndrieux Jan 25, 2021
85413e2
salt-lint: kubernetes_utils utils fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
dcd4720
salt-lint: pillar_utils utils fix "expected-2-blank-lines"
TeddyAndrieux Jan 25, 2021
3a861f8
salt-lint: volume_utils utils fix "backslash-is-redundant"
TeddyAndrieux Jan 25, 2021
04455ec
salt-lint: metalk8s_endpoints pillar fix "unused-argument"
TeddyAndrieux Feb 5, 2021
47d87a7
salt-lint: metalk8s_etcd pillar fix "broad-except"
TeddyAndrieux Jan 25, 2021
31f381f
salt-lint: metalk8s_etcd pillar fix "unused-argument"
TeddyAndrieux Feb 5, 2021
f9485af
salt-lint: metalk8s_private pillar fix "resource-leakage"
TeddyAndrieux Jan 25, 2021
7629a81
salt-lint: metalk8s pillar fix "missing-whitspace-after-comma"
TeddyAndrieux Jan 25, 2021
070c022
salt-lint: metalk8s pillar fix "broad-except"
TeddyAndrieux Jan 25, 2021
dfc592e
salt-lint: metalk8s pillar fix "unused-argument"
TeddyAndrieux Feb 5, 2021
3e36b17
salt-lint: metalk8s_solutions pillar fix "broad-except"
TeddyAndrieux Jan 25, 2021
8797a94
salt-lint: metalk8s_solutions pillar fix "unused-argument"
TeddyAndrieux Feb 5, 2021
0814b60
salt-lint: metalk8s_saltutil runner fix "undefined-variable"
TeddyAndrieux Jan 25, 2021
445650e
salt-lint: kubernetes_rbac auth fix "expected-2-blank-lines"
TeddyAndrieux Jan 25, 2021
7880d10
salt-lint: kubernetes_rbac auth fix "unused-import"
TeddyAndrieux Jan 25, 2021
f6b87f9
salt-lint: kubernetes_rbac auth fix "undefined-variable"
TeddyAndrieux Jan 25, 2021
bf7866f
salt-lint: kubernetes_rbac auth fix "unused-argument"
TeddyAndrieux Feb 5, 2021
0dbf83a
salt-lint: metalk8s_kubeconfig_info beacons fix "blacklisted-module"
TeddyAndrieux Jan 25, 2021
65efea1
salt-lint: metalk8s_kubernetes renderers fix "raise-missing-from"
TeddyAndrieux Jan 25, 2021
7d3fcab
salt-lint: metalk8s_kubernetes renderers fix "unused-argument"
TeddyAndrieux Feb 5, 2021
18aacac
salt-lint: kubernetes_nodes roster fix "unused-argument"
TeddyAndrieux Feb 5, 2021
885810a
tox: Add linting for Salt Python modules
TeddyAndrieux Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
salt-lint: containerd state fix "too-many-blank-lines" 
Remove extra blank lines
```
salt/_states/containerd.py:43: [E8303(too-many-blank-lines), ] PEP8
E303: too many blank lines (2)
```
  • Loading branch information
@TeddyAndrieux
TeddyAndrieux committed Feb 5, 2021
commit abff661692492041befa01c48c0fe0091ee1ba50
1 change: 0 additions & 1 deletion salt/_states/containerd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ def image_managed(name, archive_path=None):
'comment': '',
}


if __salt__['cri.available'](name):
ret['comment'] = 'Image already available'
ret['result'] = True
Expand Down