Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Enhance application typing - monitoring reducer #3001

Open
JBWatenbergScality opened this issue Dec 24, 2020 · 0 comments
Open

UI - Enhance application typing - monitoring reducer #3001

JBWatenbergScality opened this issue Dec 24, 2020 · 0 comments
Labels
complexity:medium Something that requires one or few days to fix kind:debt Technical debt priority:medium Medium priority issues, should only be postponed if no other option severity:minor No impact, or minor impact, on live deployments topic:ui UI-related issues

Comments

@JBWatenbergScality
Copy link
Contributor

Component:

UI, typing

Why this is needed:

This brings typesafety and enhanced developer experience to the project.

What should be done:

Add @flow annotations in ui/src/ducks/app/monitoring.js and fix all the linting issues raised. Try not using any keyword.

Test plan:

Run flow cli to ensure typing is correctly interpreted, navigate through the code base in your IDE and see if all references to monitoring reducer are correctly typed

JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality JBWatenbergScality added the topic:ui UI-related issues label Jan 22, 2021
@thomasdanan thomasdanan added complexity:medium Something that requires one or few days to fix severity:minor No impact, or minor impact, on live deployments priority:medium Medium priority issues, should only be postponed if no other option kind:debt Technical debt labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:medium Something that requires one or few days to fix kind:debt Technical debt priority:medium Medium priority issues, should only be postponed if no other option severity:minor No impact, or minor impact, on live deployments topic:ui UI-related issues
Projects
None yet
Development

No branches or pull requests

2 participants