Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Use hierarchical Route components instead of manual URL parsing #2838

Open
gdemonet opened this issue Oct 8, 2020 · 0 comments
Open

[ui] Use hierarchical Route components instead of manual URL parsing #2838

gdemonet opened this issue Oct 8, 2020 · 0 comments
Labels
complexity:medium Something that requires one or few days to fix kind:debt Technical debt priority:medium Medium priority issues, should only be postponed if no other option severity:minor No impact, or minor impact, on live deployments topic:ui UI-related issues

Comments

@gdemonet
Copy link
Contributor

gdemonet commented Oct 8, 2020

Component: ui

Why this is needed:

See #2809 (comment)

Basically, we are only using Route to choose which "page" to display, while elements within a page could also benefit from such URL matching rules.

What should be done:

Use as many Routes as possible, in all pages!

Test plan:

Everything should work the same as before (with some bugs removed, if any)
@gdemonet gdemonet added kind:debt Technical debt topic:ui UI-related issues complexity:medium Something that requires one or few days to fix labels Oct 8, 2020
This was referenced Oct 8, 2020
Merged
Merged
@thomasdanan thomasdanan added severity:minor No impact, or minor impact, on live deployments priority:medium Medium priority issues, should only be postponed if no other option labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:medium Something that requires one or few days to fix kind:debt Technical debt priority:medium Medium priority issues, should only be postponed if no other option severity:minor No impact, or minor impact, on live deployments topic:ui UI-related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasdanan @gdemonet