Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit config alertmanager in Go kubectl plugin #2483

Open
TeddyAndrieux opened this issue Apr 24, 2020 · 0 comments
Open

Add edit config alertmanager in Go kubectl plugin #2483

TeddyAndrieux opened this issue Apr 24, 2020 · 0 comments
Labels
complexity:hard Something that may require up to a week to fix kind:enhancement New feature or request priority:high High priority issues, should be worked on ASAP (after urgent issues), not postponed state:question Further information is requested topic: cluster&service configuration Anything related to cluster and service configuration persistence topic:kubectl-plugin Kubectl plugin related issues topic:monitoring Everything related to monitoring of services in a running cluster

Comments

@TeddyAndrieux
Copy link
Collaborator

TeddyAndrieux commented Apr 24, 2020

Component:

'salt', 'kubectl-plugin'

Why this is needed:

Centralized CLI

What should be done:

MetalK8s edit config alertmanager command should be part of metalk8s Go kubectl plugin

kubectl metalk8s edit config alertmanager
kubectl metalk8s edit config am
kubectl metalk8s edit config/alertmanager
kubectl metalk8s edit config/am

This command will open an editor to change the configuration for alertmanager.

TODO: Define what needs to be done according to #2467

Implementation proposal (strongly recommended):

This command will load the CSC of alertmanager display it in an editor to the user and then push the changes in Kubernetes and apply the changes using Salt.

It will be written in Go and should not use salt binaries at all, only interact directly with Salt API and should be able to run from outside of the cluster (check design documentation about Centralized CLI for more detail).

Follow kubectl best practice as much as possible.

@TeddyAndrieux TeddyAndrieux added kind:enhancement New feature or request state:question Further information is requested complexity:hard Something that may require up to a week to fix priority:high High priority issues, should be worked on ASAP (after urgent issues), not postponed topic: cluster&service configuration Anything related to cluster and service configuration persistence topic:kubectl-plugin Kubectl plugin related issues labels Apr 24, 2020
@TeddyAndrieux TeddyAndrieux added the topic:monitoring Everything related to monitoring of services in a running cluster label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:hard Something that may require up to a week to fix kind:enhancement New feature or request priority:high High priority issues, should be worked on ASAP (after urgent issues), not postponed state:question Further information is requested topic: cluster&service configuration Anything related to cluster and service configuration persistence topic:kubectl-plugin Kubectl plugin related issues topic:monitoring Everything related to monitoring of services in a running cluster
Projects
None yet
Development

No branches or pull requests

1 participant