Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Node 20 & Use latest eslint v9 #203

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Migrate to Node 20 & Use latest eslint v9 #203

merged 5 commits into from
Sep 5, 2024

Conversation

williamlardier
Copy link
Contributor

No description provided.

@williamlardier
Bump to Node20
1b3148f 
Issue: GDL-8
@williamlardier
Upgrade to eslint v9
a313de4 
- Also fixup the airbnb-base rules, as some subdeps are not
  compatible with eslint v9.
  Reference:
  https://eslint.org/blog/2024/05/eslint-compatibility-utilities/

Issue: GDL-8
@williamlardier
Remove unecessary dependency from eslint files
90918d1 
- Embed all the known config directly
- Remove airbnb dependency

Issue: GDL-8
@williamlardier
Use a local eslint config
1162c73 
- With eslintv9, creating a "rule repository" cannot follow the
  same format as using eslint locally. The first expects an object
  while the second expects an array with a different structure.

Issue: GDL-8
@williamlardier
Bump to 8.3.0
666b904 
Issue: GDL-8
@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2024

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2024

Incorrect fix version

The Fix Version/s in issue GDL-8 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.2

  • 8.3.0

Please check the Fix Version/s of GDL-8, or the target
branch of this pull request.

@williamlardier williamlardier changed the base branch from development/8.2 to development/8.3 September 4, 2024 13:38
@scality scality deleted a comment from bert-e Sep 4, 2024
@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2024

Incorrect fix version

The Fix Version/s in issue GDL-8 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.3.0

Please check the Fix Version/s of GDL-8, or the target
branch of this pull request.

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 5, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.3

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/8.2
  • stabilization/7.10.5

Please check the status of the associated issue GDL-8.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit 666b904 into development/8.3 Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benzekrimaha benzekrimaha benzekrimaha approved these changes

@KillianG KillianG KillianG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamlardier @bert-e @KillianG @benzekrimaha