Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to retrieve the namespace names for the Dynamo Admin #679

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Add method to retrieve the namespace names for the Dynamo Admin #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0153c23
Add getNamespacesNames() to DynamoAdmin
Aug 19, 2022
b1b052a
Revise according to comments
Sep 5, 2022
9036a6f
Merge branch 'master' of github.com:scalar-labs/scalardb into add_get…
Sep 6, 2022
6ca09bd
Revise according to comments
Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions ...test/java/com/scalar/db/storage/dynamo/ConsensusCommitAdminIntegrationTestWithDynamo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import com.scalar.db.transaction.consensuscommit.ConsensusCommitAdminIntegrationTestBase;
import java.util.Map;
import java.util.Properties;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

public class ConsensusCommitAdminIntegrationTestWithDynamo
extends ConsensusCommitAdminIntegrationTestBase {
Expand All @@ -23,29 +21,4 @@ protected Map<String, String> getCreationOptions() {
protected boolean isIndexOnBooleanColumnSupported() {
return false;
}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void createNamespace_ForNonExistingNamespace_ShouldCreateNamespaceProperly() {}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void createNamespace_ForExistingNamespace_ShouldThrowExecutionException() {}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void dropNamespace_ForNonExistingNamespace_ShouldThrowExecutionException() {}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void dropNamespace_ForNonExistingNamespace_ShouldDropNamespaceProperly() {}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void getNamespaceNames_ShouldReturnCreatedNamespaces() {}
}
27 changes: 0 additions & 27 deletions core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoAdminIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import com.scalar.db.api.DistributedStorageAdminIntegrationTestBase;
import java.util.Map;
import java.util.Properties;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

public class DynamoAdminIntegrationTest extends DistributedStorageAdminIntegrationTestBase {

Expand All @@ -22,29 +20,4 @@ protected Map<String, String> getCreationOptions() {
protected boolean isIndexOnBooleanColumnSupported() {
return false;
}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void createNamespace_ForNonExistingNamespace_ShouldCreateNamespaceProperly() {}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void createNamespace_ForExistingNamespace_ShouldThrowExecutionException() {}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void dropNamespace_ForNonExistingNamespace_ShouldThrowExecutionException() {}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void dropNamespace_ForNonExistingNamespace_ShouldDropNamespaceProperly() {}

@Disabled("Temporarily until admin.getNamespacesNames() is implemented")
@Test
@Override
public void getNamespaceNames_ShouldReturnCreatedNamespaces() {}
}
2 changes: 1 addition & 1 deletion core/src/integration-test/java/com/scalar/db/util/DynamoAdminTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public DynamoAdminTestUtils(Properties properties) {
.build();
metadataNamespace =
config.getNamespacePrefix().orElse("")
+ config.getTableMetadataNamespace().orElse(DynamoAdmin.METADATA_NAMESPACE);
+ config.getMetadataNamespace().orElse(DynamoAdmin.METADATA_NAMESPACE);
metadataTable = DynamoAdmin.METADATA_TABLE;
namespacePrefix = config.getNamespacePrefix().orElse("");
}
Expand Down
Loading