Add --upgrade command to Schema Loader
#1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torch3333
changed the title
--upgrade command to Schema Loader
Torch3333
force-pushed
the
add_upgrade_to_schema_loader
branch
from
345cb55 to
e44abc9
Compare
Torch3333
force-pushed
the
add_upgrade_to_schema_loader
branch
from
8892882 to
7f5e898
Compare
feeblefakie
approved these changes
Nov 2, 2023
| throws SchemaLoaderException { | ||
| Either<Path, Properties> config = new Left<>(configPath); | ||
| upgrade(config, options); | ||
| } |
There was a problem hiding this comment.
Super minor, but we probably need an empty line?
There was a problem hiding this comment.
Indeed, thank you.
It's a shame Spotless does not enforce having a blank line between method definitions.
be5165f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new
--upgradecommand to the Schema Loader, which directly calls the Admin APIupgrade()method.For more details about what
upgradedoes, please refer to #1204Related issues and/or PRs
upgrade()to Admin API #1204Changes made
Adds a new
--upgradecommand to the Schema LoaderChecklist
Additional notes (optional)
Release notes
Added a new command
--upgradeto the Schema Loader. Running this method when updating an existing environment to ScalarDB 4.X is necessary to support backward incompatible changes introduced by the new "namespaces management" feature. This command is strictly equivalent to the Admin APIupgrade()method.