Add getNamespacesNames() to DynamoAdmin

scalar-labs · Sep 2, 2022 · 02bd289 · 02bd289
1 parent 038fa93
commit 02bd289
Show file tree

Hide file tree

Showing 10 changed files with 602 additions and 179 deletions.
diff --git a/...test/java/com/scalar/db/storage/dynamo/ConsensusCommitAdminIntegrationTestWithDynamo.java b/...test/java/com/scalar/db/storage/dynamo/ConsensusCommitAdminIntegrationTestWithDynamo.java
@@ -3,8 +3,6 @@
 import com.scalar.db.transaction.consensuscommit.ConsensusCommitAdminIntegrationTestBase;
 import java.util.Map;
 import java.util.Properties;
-import org.junit.jupiter.api.Disabled;
-import org.junit.jupiter.api.Test;
 
 public class ConsensusCommitAdminIntegrationTestWithDynamo
     extends ConsensusCommitAdminIntegrationTestBase {
@@ -23,29 +21,4 @@ protected Map<String, String> getCreationOptions() {
   protected boolean isIndexOnBooleanColumnSupported() {
     return false;
   }
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void createNamespace_ForNonExistingNamespace_ShouldCreateNamespaceProperly() {}
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void createNamespace_ForExistingNamespace_ShouldThrowExecutionException() {}
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void dropNamespace_ForNonExistingNamespace_ShouldThrowExecutionException() {}
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void dropNamespace_ForNonExistingNamespace_ShouldDropNamespaceProperly() {}
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void getNamespaceNames_ShouldReturnCreatedNamespaces() {}
 }
diff --git a/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoAdminIntegrationTest.java b/core/src/integration-test/java/com/scalar/db/storage/dynamo/DynamoAdminIntegrationTest.java
@@ -3,8 +3,6 @@
 import com.scalar.db.api.DistributedStorageAdminIntegrationTestBase;
 import java.util.Map;
 import java.util.Properties;
-import org.junit.jupiter.api.Disabled;
-import org.junit.jupiter.api.Test;
 
 public class DynamoAdminIntegrationTest extends DistributedStorageAdminIntegrationTestBase {
 
@@ -22,29 +20,4 @@ protected Map<String, String> getCreationOptions() {
   protected boolean isIndexOnBooleanColumnSupported() {
     return false;
   }
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void createNamespace_ForNonExistingNamespace_ShouldCreateNamespaceProperly() {}
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void createNamespace_ForExistingNamespace_ShouldThrowExecutionException() {}
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void dropNamespace_ForNonExistingNamespace_ShouldThrowExecutionException() {}
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void dropNamespace_ForNonExistingNamespace_ShouldDropNamespaceProperly() {}
-
-  @Disabled("Temporarily until admin.getNamespacesNames() is implemented")
-  @Test
-  @Override
-  public void getNamespaceNames_ShouldReturnCreatedNamespaces() {}
 }
diff --git a/core/src/integration-test/java/com/scalar/db/util/DynamoAdminTestUtils.java b/core/src/integration-test/java/com/scalar/db/util/DynamoAdminTestUtils.java
@@ -49,7 +49,7 @@ public DynamoAdminTestUtils(Properties properties) {
             .build();
     metadataNamespace =
         config.getNamespacePrefix().orElse("")
-            + config.getTableMetadataNamespace().orElse(DynamoAdmin.METADATA_NAMESPACE);
+            + config.getMetadataNamespace().orElse(DynamoAdmin.METADATA_NAMESPACE);
     metadataTable = DynamoAdmin.METADATA_TABLE;
     namespacePrefix = config.getNamespacePrefix().orElse("");
   }