-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Bump JLine 2 to 9a88bc4
#7952
Conversation
hmm, are we sure that removing jansi is a good idea in the JLine 2 context? just asking; I don't remember why JLine 2 is even still present in this repo |
I see that JLine 2 is still present even on the |
I honestly have no clue too... At this point only Eugene and perhaps Lukas / som-snytt knows. Only thing I know is that some legacy Scala 2.12 |
I mean thinking positively we all get to practice working with legacy code + unmaintained legacy dep! |
oh, Scala 2.12, sigh, that's plausible. still, I wonder if we should try ripping it out to verify if it's still needed |
My guess is we'd need to support layered ClassLoader unless we drop the support of some Scala versions, which I don't think is worth it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
it did cross my mind to try to convince you to drop support for building 2.12 projects 😈 but I'm not sure I could even convince myself, much as I would like to see 2.12 die |
Contains sbt/jline2@9a88bc4