Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[disp] Rename disp_pixel_random to disp_graph_pixel_random #2664

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[disp] Rename disp_pixel_random to disp_graph_pixel_random #2664

merged 1 commit into from
Jan 13, 2025

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jan 4, 2025 •
edited
Loading

Fixes #2661

Do I need to add anything to make the old name still work?

@cool-RR cool-RR changed the title [disp] Rename disp_pixel_random to disp_graph_pixel_random #2661 [disp] Rename disp_pixel_random to disp_graph_pixel_random Jan 4, 2025
@cool-RR cool-RR marked this pull request as ready for review January 4, 2025 21:54
@cool-RR
Copy link
Contributor Author

cool-RR commented Jan 10, 2025

Bump.

@saulpw
Copy link
Owner

saulpw commented Jan 12, 2025 •
edited by anjakefala
Loading

Thanks for pulling this together, @cool-RR. We do need to add a line to the end of deprecated.py:

vd.optalias('disp_pixel_random', 'disp_graph_pixel_random')  #2661

But if that's the only disp_pixel_random remaining in the codebase after this PR, then we're good.

@cool-RR
Copy link
Contributor Author

cool-RR commented Jan 12, 2025

Done.

saulpw
saulpw approved these changes Jan 13, 2025
View reviewed changes
Copy link
Owner

@saulpw saulpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing an inconsistency, @cool-RR !

@anjakefala anjakefala merged commit e56bbaf into saulpw:develop Jan 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulpw saulpw saulpw approved these changes

Assignees
No one assigned
Labels
waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename options.disp_pixel_random to include graph
3 participants
@cool-RR @saulpw @anjakefala