Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows-] update windows-curses version to 2.4 #2119 #2563

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

midichef
Copy link
Contributor

@midichef midichef commented Oct 14, 2024

windows-curses has released their version 2.4.0. They have updated the version of PDCurses they use, to fix problems inputting some keypresses. This version change should fix #1841, #2062, #2119, and #2267.

@daviewales could you see if installing windows_curses 2.4.0 works well with visidata? In particular, that visidata starts up as usual, without silently exiting immediately, and that the keypresses " and ] are detected?

@daviewales
Copy link
Contributor

daviewales commented Oct 15, 2024

Tested with Python 3.12.
All of the above work. (starts, can use " and ].)
I noticed that it does not detect mouse clicks however.

@anjakefala
Copy link
Collaborator

@daviewales Does the trade-off feel worth it to you? Improving support of keystrokes, but losing mouseclicks? Saul and I don't use Windows, so this is up to the community that does.

@daviewales
Copy link
Contributor

To add to the tradeoff: #2267

I'd say that launching on 3.12 is fairly essential!

@anjakefala
Copy link
Collaborator

Ah, good call!

@anjakefala anjakefala merged commit 6f68b52 into saulpw:develop Nov 13, 2024
13 checks passed
@midichef
Copy link
Contributor Author

midichef commented Nov 30, 2024

windows_curses 2.4.0 does not support Python 3.13. It's possible that Windows users trying to install the visidata develop branch with Python 3.13 will get an error:

ERROR: Could not find a version that satisfies the requirement windows-curses (from versions: none)
ERROR: No matching distribution found for windows-curses

(seen in the windows_curses repo as Issues # 69 and # 70)

This will be fixed soon, as a fix has been submitted as PR # 71 in the windows_curses repo. I expect a 2.4.1 release of windows_curses to incorporate the fix. When it comes out, we should require it.

Until then, for any affected user, I'd recommend using Python 3.12.

@midichef midichef deleted the win_curses_pdcurses branch December 1, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keystroke ] not detected on Windows
3 participants