Skip to content

Commit

Permalink
Merge pull request kubernetes#21796 from nikhiljindal/deploymente2eLogs
Browse files Browse the repository at this point in the history
deployment e2e test flake: Print the remaining pods to debug test flake
  • Loading branch information
dchen1107 committed Feb 24, 2016
2 parents 7a8ea15 + ac6188c commit b19102b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/e2e/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,9 @@ func stopDeployment(c *clientset.Clientset, oldC client.Interface, ns, deploymen
Expect(err).NotTo(HaveOccurred())
Expect(rss.Items).Should(HaveLen(0))
Logf("ensuring deployment %s pods were deleted", deploymentName)
var pods *api.PodList
if err := wait.PollImmediate(time.Second, wait.ForeverTestTimeout, func() (bool, error) {
pods, err := c.Core().Pods(ns).List(api.ListOptions{})
pods, err = c.Core().Pods(ns).List(api.ListOptions{})
if err != nil {
return false, err
}
Expand All @@ -193,7 +194,7 @@ func stopDeployment(c *clientset.Clientset, oldC client.Interface, ns, deploymen
}
return false, nil
}); err != nil {
Failf("Failed to remove deployment %s pods!", deploymentName)
Failf("Err : %s\n. Failed to remove deployment %s pods : %+v", deploymentName, pods)
}
}

Expand Down

0 comments on commit b19102b

Please sign in to comment.