Skip to content

Commit

Permalink
Comment out calls to httptest.Server.Close() to work around
Browse files Browse the repository at this point in the history
golang/go#12262 . See kubernetes#19254 for
more details. This change should be reverted when we upgrade
to Go 1.6.
  • Loading branch information
soltysh committed Feb 11, 2016
1 parent 2f23ba6 commit 72654d3
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions plugin/pkg/auth/authenticator/token/oidc/oidc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ func TestOIDCDiscoveryNoKeyEndpoint(t *testing.T) {
t.Fatalf("Cannot load cert/key pair: %v", err)
}
srv.StartTLS()
defer srv.Close()
// TODO: Uncomment when fix #19254
// defer srv.Close()

op.pcfg = oidc.ProviderConfig{
Issuer: srv.URL,
Expand Down Expand Up @@ -274,7 +275,8 @@ func TestOIDCDiscoverySecureConnection(t *testing.T) {
t.Fatalf("Cannot load cert/key pair: %v", err)
}
tlsSrv.StartTLS()
defer tlsSrv.Close()
// TODO: Uncomment when fix #19254
// defer tlsSrv.Close()

op.pcfg = oidc.ProviderConfig{
Issuer: tlsSrv.URL,
Expand Down Expand Up @@ -309,7 +311,8 @@ func TestOIDCAuthentication(t *testing.T) {
t.Fatalf("Cannot load cert/key pair: %v", err)
}
srv.StartTLS()
defer srv.Close()
// TODO: Uncomment when fix #19254
// defer srv.Close()

op.pcfg = oidc.ProviderConfig{
Issuer: srv.URL,
Expand Down

0 comments on commit 72654d3

Please sign in to comment.