Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Currently active item in structured nav blinks during certain transitions #420

Closed
elynema opened this issue Feb 15, 2024 · 4 comments
Closed

[BUG] Currently active item in structured nav blinks during certain transitions #420

elynema opened this issue Feb 15, 2024 · 4 comments
Assignees
@Dananji

Comments

@elynema
Copy link

elynema commented Feb 15, 2024 •
edited by joncameron
Loading

Description

Under certain circumstances, the title of the selected playlist item in the structured navigation will blink between 1 and 4 times. This happens:

Playlist context:

  • when clicking on an item in the playlist
  • when using the next button to advance to the next canvas
  • when starting/stopping playback of an item in a playlist
  • when the last item in a playlist finishes

Media item page context:

  • when clicking on a timespan in the structured nav on a media item
  • when starting/stopping playback of a timespan in the structured nav
  • when using the prev/next button to advance to a timespan in the structured nav (ex: navigating to a section that begins with a timespan highlighted)

This video shows some examples:

Private Zenhub Video

On the item page:
Feb-28-2024 14-57-28

See past history on #370.
@elynema elynema changed the title [BUG] Playlist items blink during certain transitions [BUG] Currently active item in structured nav blinks during certain transitions Feb 15, 2024
@joncameron
Copy link
Contributor

Could be due to state updates happening multiple times quickly.

@Dananji Dananji self-assigned this Mar 11, 2024
This was referenced Mar 11, 2024
Merged
Merged
@elynema
Copy link
Author

elynema commented Mar 22, 2024

@charumitraravi I can't assign this one to you b/c you're not in the Ramp repository, but can you take a look at this one? The ticket description lists the times that we were seeing blinking in the navigation as a checklist to run through.

@charumitraravi
Copy link
Collaborator

Tested both the playlist and the media object page. Although the blinking issue has been resolved in the context of the structured nav item, the entire page seems to flicker now. Tested the same scenario on Avalon staging, and I was unable to replicate the page flicker.

Page flicker on media object page

Screen.Recording.2024-03-22.at.2.48.46.PM.mov

@joncameron joncameron mentioned this issue Mar 27, 2024
Open
1 task
@joncameron
Copy link
Contributor

Created #462 for the broader flickering issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dananji Dananji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Dananji @joncameron @charumitraravi @elynema