Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate and expose type helpers #5028

Open
jhefferman-sfdc opened this issue Dec 10, 2024 · 2 comments
Open

Consolidate and expose type helpers #5028

jhefferman-sfdc opened this issue Dec 10, 2024 · 2 comments
Labels
SSR USER STORY

Comments

@jhefferman-sfdc
Copy link
Contributor

jhefferman-sfdc commented Dec 10, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Redundant helper methods

Describe the solution you'd like

Consider whether the type helper functions defined in template-compiler -> estree could be exported and used in other contexts. Some type changes would be required.

Additional context

An example would be:

lwc/packages/@lwc/template-compiler/src/shared/estree.ts

Line 61 in ee2edae

export function isLiteral(node: t.BaseNode): node is t.Literal {

Which could serve as a replacement for the same function in shared.ts if the types were aligned.
@git2gus Git2Gus
Copy link

git2gus bot commented Dec 10, 2024

This issue has been linked to a new work item: W-17405443

@jhefferman-sfdc jhefferman-sfdc mentioned this issue Dec 10, 2024
Merged
@nolanlawson
Copy link
Collaborator

export * as utils in @lwc/template-compiler seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SSR USER STORY
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nolanlawson @jhefferman-sfdc