Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows10メニュー対応 #130

Merged
merged 7 commits into from
Jun 23, 2018
Merged

Windows10メニュー対応 #130

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3fe33ad
Windows10メニュー対応
KENCHjp Jun 17, 2018
802cf2b
Windows10と判定したときのsakura.exeのショートカットを相対パス指定だったのをuserstartmenuに修正
KENCHjp Jun 17, 2018
db96aaa
レビュー結果反映
KENCHjp Jun 17, 2018
f1a4e3c
Windows10判定を10以降に修正。
KENCHjp Jun 17, 2018
fafcfaf
Windows10の判定をMajorのみ10以上判定にする。
KENCHjp Jun 17, 2018
89784ab
今回修正分不要コード削除
KENCHjp Jun 17, 2018
aad3530
PRレビュー結果反映
KENCHjp Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Windows10の判定をMajorのみ10以上判定にする。
  • Loading branch information
@KENCHjp
KENCHjp committed Jun 23, 2018
commit fafcfaf9d7074da83d436c576dcd4ed37af24d18
4 changes: 2 additions & 2 deletions installer/sakura.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,8 @@ var
S: String;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この変数使ってますか？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sですよね。
つかってないっす^^
完全に盲点にはいってました。

begin
GetWindowsVersionEx(Version);
if (Version.Major = 10)
{ (Version.Minor = 0) and
if (Version.Major >= 10)
{ and (Version.Minor = 0) and
(Version.ProductType = VER_NT_WORKSTATION) } then
begin
Result := True;
Expand Down