ダイアログリソース整理　IDC_STATIC_URL_GITHUB_CAPTION

表示非表示をコードで切り替えていたのを変更。ビルド元ソースの情報は、実行時に変わることはないので埋め込んでしまう。
sakura-editor · Oct 21, 2018 · 0107213 · 0107213
1 parent 48dbf1a
commit 0107213
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/sakura_core/dlg/CDlgAbout.cpp b/sakura_core/dlg/CDlgAbout.cpp
@@ -276,11 +276,6 @@ BOOL CDlgAbout::OnInitDialog( HWND hwndDlg, WPARAM wParam, LPARAM lParam )
 	m_UrlGitHubPRWnd.SetSubclassWindow( GetItemHwnd( IDC_STATIC_URL_GITHUB_PR ) );
 #endif
 
-	// GitHub のリンクのテキスト
-#if !defined(GITHUB_COMMIT_URL) && !defined(GITHUB_COMMIT_URL_PR_HEAD)
-	ShowWindow(GetItemHwnd(IDC_STATIC_URL_GITHUB_CAPTION), SW_HIDE);
-#endif
-
 	//	Oct. 22, 2005 genta 原作者ホームページが無くなったので削除
 	//m_UrlOrgWnd.SubclassWindow( GetItemHwnd(IDC_STATIC_URL_ORG ) );
 

diff --git a/sakura_core/sakura_rc.rc b/sakura_core/sakura_rc.rc
@@ -116,7 +116,9 @@ BEGIN
     LTEXT           "Build URL:", IDC_STATIC_URL_APPVEYOR_CAPTION, 33, 123, 71, 8, NOT WS_GROUP
     LTEXT           APPVEYOR_BUILD_TEXT, IDC_STATIC_URL_APPVEYOR_BUILD, 101, 123, 120, 8, SS_NOTIFY | NOT WS_GROUP | WS_TABSTOP
 #endif
+#if defined( APPVEYOR_SHORTHASH ) || defined( APPVEYOR_PULL_REQUEST_NUMBER )
     LTEXT           "GitHub URL:", IDC_STATIC_URL_GITHUB_CAPTION, 33, 133, 50, 8, NOT WS_GROUP
+#endif
 #ifdef APPVEYOR_SHORTHASH
     LTEXT           APPVEYOR_SHORTHASH, IDC_STATIC_URL_GITHUB_COMMIT, 101, 133, 30, 8, SS_NOTIFY | NOT WS_GROUP | WS_TABSTOP
 #endif

diff --git a/sakura_lang_en_US/sakura_lang_rc.rc b/sakura_lang_en_US/sakura_lang_rc.rc
@@ -121,7 +121,9 @@ BEGIN
     LTEXT           "Build URL:", IDC_STATIC_URL_APPVEYOR_CAPTION, 33, 123, 71, 8, NOT WS_GROUP
     LTEXT           APPVEYOR_BUILD_TEXT, IDC_STATIC_URL_APPVEYOR_BUILD, 101, 123, 120, 8, SS_NOTIFY | NOT WS_GROUP | WS_TABSTOP
 #endif
+#if defined( APPVEYOR_SHORTHASH ) || defined( APPVEYOR_PULL_REQUEST_NUMBER )
     LTEXT           "GitHub URL:", IDC_STATIC_URL_GITHUB_CAPTION, 33, 133, 50, 8, NOT WS_GROUP
+#endif
 #ifdef APPVEYOR_SHORTHASH
 	LTEXT           APPVEYOR_SHORTHASH, IDC_STATIC_URL_GITHUB_COMMIT, 101, 133, 30, 8, SS_NOTIFY | NOT WS_GROUP | WS_TABSTOP
 #endif