Moving lint tests to CircleCI from Travis (oppia#6453)

* First * First * Second * Third * Fourth * Reset * lint tests on circleci
saketringsia · Mar 15, 2019 · 7eb4ba2 · 7eb4ba2
1 parent e926756
commit 7eb4ba2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -45,7 +45,7 @@ jobs:
           command: |
             bash scripts/install_third_party.sh
             python scripts/third_party_size_check.py
-            python scripts/pre_commit_linter.py --path=.
+            python scripts/pre_commit_linter.py --path=. --verbose
       - save_cache:
           key: third-party-cache-{{ checksum "date" }}
           paths:
@@ -92,9 +92,9 @@ workflows:
   circleci_tests:
     jobs:
       - setup
-      # - lint_tests:
-      #     requires:
-      #       - setup
+      - lint_tests:
+          requires:
+            - setup
       - frontend_tests:
           requires:
             - setup

diff --git a/.travis.yml b/.travis.yml
@@ -19,9 +19,9 @@ branches:
 
 env:
   matrix:
-    - RUN_LINT=true
     # These lines are commented out because these checks are being run on CircleCI
     # here: https://circleci.com/gh/oppia/oppia
+    # - RUN_LINT=true
     # - RUN_FRONTEND_TESTS=true
     # - RUN_BACKEND_TESTS=true REPORT_BACKEND_COVERAGE=false EXCLUDE_LOAD_TESTS=true
     # TODO(sll): Reinstate this when we can get it to run in reasonable time.
@@ -106,11 +106,11 @@ install:
 - bash scripts/install_third_party.sh
 
 script:
-- if [ "$RUN_LINT" == 'true' ]; then python scripts/third_party_size_check.py; python scripts/pre_commit_linter.py --path=. --verbose; fi
 # These lines are commented out because these checks are being run on CircleCI
 # here: https://circleci.com/gh/oppia/oppia
 # Travis aborts test run if nothing is printed back to STDOUT for some time.
 # -x is used to avoid that.
+# - if [ "$RUN_LINT" == 'true' ]; then python scripts/third_party_size_check.py; python scripts/pre_commit_linter.py --path=. --verbose; fi
 # - if [ "$RUN_FRONTEND_TESTS" == 'true' ]; then travis_retry bash -x scripts/run_frontend_tests.sh --run-minified-tests=true; fi
 # - if [ "$RUN_BACKEND_TESTS" == 'true' ] && [ "$REPORT_BACKEND_COVERAGE" == 'true' ] && [ "$EXCLUDE_LOAD_TESTS" == 'true' ]; then bash scripts/run_backend_tests.sh --generate_coverage_report --exclude_load_tests; fi
 # - if [ "$RUN_BACKEND_TESTS" == 'true' ] && [ "$REPORT_BACKEND_COVERAGE" == 'false' ] && [ "$EXCLUDE_LOAD_TESTS" == 'true' ]; then bash scripts/run_backend_tests.sh --exclude_load_tests; fi