Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature_add_deployment_annotations #216

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Feature_add_deployment_annotations #216

merged 1 commit into from
Nov 14, 2024

Conversation

jgalais
Copy link
Contributor

@jgalais jgalais commented Jul 9, 2024

Hello,

I added Deployment annotations because it's mandatory for some applications like Reloader (https://github.com/stakater/Reloader).

Regards,
jgalais

@jgalais jgalais force-pushed the Feature_add_deployment_annotations branch from 1bfda37 to 765bf1a Compare July 9, 2024 12:56
sagikazarmark
sagikazarmark requested changes Aug 26, 2024
View reviewed changes
Copy link
Owner

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add it to values.yaml?

https://github.com/sagikazarmark/helm-charts/blob/master/charts/sftpgo/values.yaml#L94

@jgalais jgalais force-pushed the Feature_add_deployment_annotations branch 2 times, most recently from 417e93f to 7d75e67 Compare October 24, 2024 13:40
@jgalais
Copy link
Contributor Author

jgalais commented Oct 24, 2024

@sagikazarmark I added deploymentAnnotations inside values.yaml.

Regards,
jgalais

@jgalais jgalais requested a review from sagikazarmark October 24, 2024 13:43
sagikazarmark
sagikazarmark requested changes Oct 25, 2024
View reviewed changes
Copy link
Owner

@sagikazarmark sagikazarmark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update chart version

https://github.com/sagikazarmark/helm-charts/blob/master/.github/CONTRIBUTING.md

@jgalais jgalais force-pushed the Feature_add_deployment_annotations branch from 9927f48 to 6799ae9 Compare October 25, 2024 12:14
@jgalais jgalais requested a review from sagikazarmark October 25, 2024 12:14
@jgalais
Copy link
Contributor Author

jgalais commented Oct 25, 2024

I updated the chart version.

Regards,
jgalais

sagikazarmark
sagikazarmark requested changes Oct 25, 2024
View reviewed changes
Copy link
Owner

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing:

README files are not up to date (run 'make docs')

@jgalais
Feature_add_deployment_annotations
e6698a5 
- Add deployment annotation feature
- Update chart version
@jgalais jgalais force-pushed the Feature_add_deployment_annotations branch from 6799ae9 to e6698a5 Compare October 25, 2024 12:22
@jgalais jgalais requested a review from sagikazarmark October 25, 2024 12:22
@jgalais
Copy link
Contributor Author

jgalais commented Oct 25, 2024

CI is failing:

README files are not up to date (run 'make docs')

I fixed that.

regards,
Jgalais

@jgalais
Copy link
Contributor Author

jgalais commented Nov 7, 2024 •
edited
Loading

Hello,

Please can you validate this PR to add this feature and avoid to fork your registry to use it ?

Regards,
Jgalais

@jgalais
Copy link
Contributor Author

jgalais commented Nov 14, 2024 •
edited
Loading

@sagikazarmark Please can you merge this PR and create a new release on the master branch ?

Thank you,
Jgalais

@sagikazarmark sagikazarmark merged commit ea228b1 into sagikazarmark:master Nov 14, 2024
10 checks passed
@sagikazarmark
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark approved these changes

Assignees
No one assigned
Labels
sftpgo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgalais @sagikazarmark