test: allow phpunit 10 #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage 98.75% 98.75%
Complexity 89 89
=========================================
Files 4 4
Lines 160 160
=========================================
Hits 158 158
Misses 2 2 ☔ View full report in Codecov by Sentry. |
phil-davis
force-pushed
the
allow-modern-phpunit
branch
from
9833f80
to
53d4e03
Compare
phil-davis
force-pushed
the
allow-modern-phpunit
branch
from
53d4e03
to
164a288
Compare
phil-davis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try this in
cachefirst just to see what happens.I renamed
AbstractCacheTesttoAbstractCacheTestClassand that stopped the warning.phpunitand asking to produce test coverage data, but hadn't specified the coverage driver "pcov". PHPunit 9 had not made that a failure, but PHPunit 10 fails (correctly) in that case. I fixed it.PHPunit 10 also gives the message:
That does not fail the test pipeline. We can't do anything about that, because we need to have the phpunit XML config in the version 9 format so that we can use it on PHP 7.4. An alternative would be to update it, and put the old phpunit XML in a different file that we use when running PHPunit 9. That seems to complex/tricky.