Free filerec compared trees after find_dupes

We don't need these hanging around any more. Signed-off-by: Mark Fasheh <mfasheh@suse.de>
rx80 · Sep 21, 2016 · 2bb8309 · 2bb8309
1 parent fae80ce
commit 2bb8309
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/filerec.c b/filerec.c
@@ -209,6 +209,14 @@ static void free_compared_tree(struct filerec *file)
 	abort_on(!RB_EMPTY_ROOT(&file->comparisons));
 }
 
+void free_all_filerec_compared(void)
+{
+	struct filerec *file;
+
+	list_for_each_entry(file, &filerec_list, rec_list)
+		free_compared_tree(file);
+}
+
 static int cmp_filerecs(struct filerec *file1, uint64_t file2_inum,
 			uint64_t file2_subvolid)
 {

diff --git a/filerec.h b/filerec.h
@@ -142,7 +142,7 @@ struct filerec_token *filerec_token_new(struct filerec *file);
 
 int filerecs_compared(struct filerec *file1, struct filerec *file2);
 int mark_filerecs_compared(struct filerec *file1, struct filerec *file2);
-
+void free_all_filerec_compared(void);
 
 struct fiemap_ctxt;
 struct fiemap_ctxt *alloc_fiemap_ctxt(void);

diff --git a/find_dupes.c b/find_dupes.c
@@ -472,9 +472,12 @@ static int find_all_dupes_filewise(struct hash_tree *tree,
 	wait_update_extent_search_status(pool);
 
 out:
-
 	g_thread_pool_free(pool, FALSE, TRUE);
-
+	/*
+	 * Save memory by freeing each filerec compared tree once all
+	 * threads have finished.
+	 */
+	free_all_filerec_compared();
 	return ret;
 }