Add num_points to fps as an alternative to ratio #218
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 97.32% 97.52% +0.19%
==========================================
Files 11 11
Lines 224 242 +18
==========================================
+ Hits 218 236 +18
Misses 6 6 ☔ View full report in Codecov by Sentry. |
LarsHaalck
force-pushed
the
master
branch
2 times, most recently
from
5657169 to
d552641
Compare
|
Hello @LarsHaalck @rusty1s, Thank you for this valuable contribution! The addition of num_points as an alternative to ratio in the fps function will be highly beneficial for various use cases. I am currently planning to introduce a new feature in PyTorch Geometric that relies on an optimized fps implementation with a fixed number of points. Could you please share any updates on the approval or merge timeline for this PR? Thank you in advance for your response and for your work on this improvement! Best regards, |
The current implementation of farthest point sampling only allows to set a ratio value to define the number of output points. Some use-cases require a fixed number of output points.
This PR adds an argument
num_pointsto allow this. I also added some tests. The implementation raises a runtime exception if the number of requested points is greater than the number of input points.