Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-vmm/vm-virtio
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: virtio-vsock-v0.8.0
Choose a base ref
...
head repository: rust-vmm/vm-virtio
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 14 commits
  • 64 files changed
  • 6 contributors

Commits on Oct 29, 2024

  1. build(deps): bump rust-vmm-ci from 209c04e to 1150c47

    Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `209c04e` to `1150c47`.
    - [Commits](rust-vmm/rust-vmm-ci@209c04e...1150c47)
    
    ---
    updated-dependencies:
    - dependency-name: rust-vmm-ci
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    [SG] Updated coverage score since we fixed its calculation, see
    rust-vmm/rust-vmm-ci#171
    
    Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
    dependabot[bot] authored and epilys committed Oct 29, 2024
    Copy the full SHA
    adbf691 View commit details

Commits on Nov 19, 2024

  1. virtio-bindings: regenerate with Linux 6.12

    Signed-off-by: Alyssa Ross <hi@alyssa.is>
    alyssais authored and epilys committed Nov 19, 2024
    Copy the full SHA
    fadbbc1 View commit details

Commits on Jan 10, 2025

  1. vsock: fix non_local_definitions warning

    Remove unnecessary `impl` by inlining the method call body into the
    place that calls it directly.
    
    Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
    epilys committed Jan 10, 2025
    Copy the full SHA
    35e84ab View commit details
  2. virtio-queue: fix clippy::needless-lifetimes lint

    Remove explicitly named lifetimes that can be elided by the compiler to
    silence clippy lint.
    
    Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
    epilys committed Jan 10, 2025
    Copy the full SHA
    8aff76a View commit details
  3. virtio-blk: add missing method doc in tests

    Add missing doc comment in #[cfg(test)] Request::new() method to silence
    the `missing_docs` rustc lint.
    
        error: missing documentation for an associated function
           --> virtio-blk/src/request.rs:278:9
            |
        278 | /         pub fn new(
        279 | |             request_type: RequestType,
        280 | |             data: Vec<(GuestAddress, u32)>,
        281 | |             sector: u64,
        282 | |             status_addr: GuestAddress,
        283 | |         ) -> Self {
            | |_________________^
            |
        note: the lint level is defined here
           --> virtio-blk/src/lib.rs:8:9
            |
        8   | #![deny(missing_docs)]
            |         ^^^^^^^^^^^^
    
    Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
    epilys committed Jan 10, 2025
    Copy the full SHA
    7035c0a View commit details
  4. build(deps): bump rust-vmm-ci from 1150c47 to 09aef99

    Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `1150c47` to `09aef99`.
    - [Commits](rust-vmm/rust-vmm-ci@1150c47...09aef99)
    
    ---
    updated-dependencies:
    - dependency-name: rust-vmm-ci
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and epilys committed Jan 10, 2025
    Copy the full SHA
    f8c6b0d View commit details

Commits on Jan 16, 2025

  1. Add license files in published crate part of this workspace

    Add a symbolic link to license files in each crate we publish
    to avoid problems like this:
    
        $ rust2rpm -t fedora -a -s virtio-vsock 0.6.0
        ERROR: No license files were detected. In almost all cases, this is an issue
               with the upstream project that should be reported.
    
    In the other unpublished crates we have different licenses that we
    should resolve before publishing and link the right license files.
    
    Fixes: #298
    Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
    stefano-garzarella committed Jan 16, 2025
    Copy the full SHA
    67d5be7 View commit details

Commits on Jan 31, 2025

  1. virtio-bindings: use bindgen library from build.rs

    Since commit 3e51e2d ("virtio-bindings: regenerate with bindgen 0.70.1")
    there are compile-time alignment checks in virtio-bindings code. These
    checks are specific to the architecture where bindgen was run and they
    can break builds on other architectures.
    
    Here is an example i686 build failure after upgrading from
    virtio-bindings 0.2.2 to 0.2.4:
    https://koji.fedoraproject.org/koji/taskinfo?taskID=127997322
    
    The bindgen User Guide recommends generating bindings from build.rs
    because it avoids portability issues and the need to maintain a copy of
    the bindings for each target:
    https://rust-lang.github.io/rust-bindgen/library-usage.html
    
    Introduce an import-linux-headers.sh script that copies required virtio
    headers from a Linux headers tree into include/. Do not distribute the
    full Linux headers tree because it is large and has falls under various
    software licenses that are not compatible with this crate's license.
    
    Generate the actual bindings at compile-time in build.rs and then
    include!() the output from src/lib.rs.
    
    You can verify that the generated bindings from Linux 6.12 have not
    changed significantly for x86_64 by diffing them against the previous
    commit. For example:
    --- orig/virtio_gpu.rs
    +++ new/virtio_gpu.rs
    @@ -1,4 +1,4 @@
    -/* automatically generated by rust-bindgen 0.70.1 */
    +/* automatically generated by rust-bindgen 0.71.1 */
    
     #[repr(C)]
     #[derive(Default)]
    @@ -58,7 +58,7 @@
     pub const VIRTIO_GPU_MAP_CACHE_WC: u32 = 3;
     pub type __u8 = ::std::os::raw::c_uchar;
     pub type __u32 = ::std::os::raw::c_uint;
    -pub type __u64 = ::std::os::raw::c_ulonglong;
    +pub type __u64 = ::std::os::raw::c_ulong;
     pub type __le32 = __u32;
     pub type __le64 = __u64;
     pub const virtio_gpu_ctrl_type_VIRTIO_GPU_UNDEFINED: virtio_gpu_ctrl_type = 0
    
    The __u64 change is due to how <linux/types.h> defined __u64. We should
    avoid using that non-BSD licensed header. The result is equivalent now
    that the bindings are generated at compile-time.
    
    Fixes: #326
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
    stefanhaRH authored and stsquad committed Jan 31, 2025
    Copy the full SHA
    2c21f25 View commit details

Commits on Feb 10, 2025

  1. virtio-bindings: Prepare v0.2.5 release

    Changed
    
    - Regenerate bindings with Linux 6.12.
    - Introduced bindgen build dependency and its clang development package
      dependency. See bindgen fix below for why this was necessary.
    
    Fixed
    
    - Add license files.
    - Use bindgen library from build.rs to fix i686 builds due to x86_64-specific
      alignment checks.
    
    Closes: #328
    Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
    stefano-garzarella committed Feb 10, 2025
    Copy the full SHA
    90578b1 View commit details

Commits on Feb 27, 2025

  1. build(deps): bump rust-vmm-ci from 09aef99 to 2d733b0

    Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `09aef99` to `2d733b0`.
    - [Commits](rust-vmm/rust-vmm-ci@09aef99...2d733b0)
    
    ---
    updated-dependencies:
    - dependency-name: rust-vmm-ci
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and stefano-garzarella committed Feb 27, 2025
    Copy the full SHA
    f725241 View commit details

Commits on Mar 4, 2025

  1. Add desc module and split.rs

    Add a new module called desc for split and packed descriptor.
    split.rs represents the split descriptor and packed.rs will
    represent the packed descriptor.
    The Descriptor struct in mod.rs represents the memory layout
    of the split and packed descriptor.
    
    Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
    uran0sH authored and epilys committed Mar 4, 2025
    Copy the full SHA
    4eb6318 View commit details
  2. Use desc/split and remove descriptor.rs

    Use 'virtio_queue::desc::split::Descriptor' to replace
    'virtio_queue::Descriptor'.
    
    Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
    uran0sH authored and epilys committed Mar 4, 2025
    Copy the full SHA
    db412a3 View commit details
  3. Add packed descriptor

    Add the packed descriptor for support packed vring.
    
    Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
    uran0sH authored and epilys committed Mar 4, 2025
    Copy the full SHA
    5fb43d4 View commit details
  4. Update virtio-queue CHANGELOG

    Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
    uran0sH authored and epilys committed Mar 4, 2025
    Copy the full SHA
    257c73d View commit details
Loading