only enable jemalloc on non-windows targets #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tzemanovic
force-pushed
the
tomas/no-jemalloc-win
branch
from
20f158a to
63615e0
Compare
aleksuss
reviewed
Jul 4, 2024
librocksdb-sys/build.rs
Outdated
| @@ -206,14 +206,14 @@ fn build_rocksdb() { | |||
| "port/win/win_logger.cc", | |||
| ]); | |||
|
|
|||
| if cfg!(feature = "jemalloc") { | |||
| if cfg!(all(feature = "jemalloc", not(windows))) { | |||
| lib_sources.push("port/win/win_jemalloc.cc"); | |||
There was a problem hiding this comment.
I don't get it. Why do we need to add a source file related to the windows on not(windows) target?
There was a problem hiding this comment.
yeah good point, this is pointless
There was a problem hiding this comment.
I just removed this port c195c31
tzemanovic
force-pushed
the
tomas/no-jemalloc-win
branch
from
c195c31 to
abdfd87
Compare
tzemanovic
force-pushed
the
tomas/no-jemalloc-win
branch
from
abdfd87 to
5787324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, I'd like to use "jemalloc" on non-windows platforms using an optional feature in my app, but it's currently not possible to declare platform specific features in Cargo.toml (rust-lang/cargo#1197). To workaround it, I'd like to change
librocksdb-systo allow to use"jemalloc"on windows but without having any effect.Edit: the reason
"jemalloc"doesn't compile on windows is that https://crates.io/crates/tikv-jemallocator doesn't support it (tikv/jemallocator#22)