Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version #267

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Bump version #267

merged 1 commit into from
Jun 26, 2018

Conversation

jthemphill
Copy link
Contributor

I'm still stuck on a version that's 1.5 years old!

I'm still stuck on a version that's 1.5 years old!
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis
Copy link
Contributor

I have no idea what this does but...seems fine?

@tromey
Copy link
Contributor

tromey commented Apr 25, 2018

It makes it a bit simpler to update if you aren't using MELPA. Maybe we also need to push a tag to make melpa-stable bump? See #87

@nikomatsakis
Copy link
Contributor

So...shall we land it? :)

@nikomatsakis nikomatsakis merged commit 106aeab into rust-lang:master Jun 26, 2018
@4lex1v
Copy link

4lex1v commented Jun 26, 2018

Could you please tag the branch also =)?

@jthemphill
Copy link
Contributor Author

jthemphill commented Jun 27, 2018 via email

@pnkfelix pnkfelix mentioned this pull request Mar 4, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Mar 4, 2019

sorry for the lack of action here for months; clearly the people with all the power here haven't accepted all the associated responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants