Skip to content

The Semantics API is prone to panics #17367

Open
@Veykril

Description

We tend to have a lot of IDE features randomly panic simply because a node that is being used in a lookup is not cached in the parse tree cache. This is really annoying and keeps getting worse and better every few weeks. We ought to remodel the APIs involved to either make this practically impossible (any node that may be produced immediately being cached) or have the cache be redundant for lookups (passing the corresponding file ids, making the find_file internal function obsolete).

The former would be nicer in terms of usability, but the latter will ensure the problem from not occuring anymore (unless the file id is mismatched but that's is a lot more difficult to run into than it is to not cache a node).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-idegeneral IDE featuresBroken WindowBugs / technical debt to be addressed immediatelyI-panic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions