Skip to content

Request retrying needs to update file offsets in the tried requests #13720

Open
@Veykril

Description

When a document change notification comes in, we currently cancel all outstanding requests and retry them after we changed the document, this obviously causes a problem: Offsets in those requests are now out of sync with the document which can cause a variety of odd issues (and panics). We need to fix them up before retrying again.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Broken WindowBugs / technical debt to be addressed immediatelyC-bugCategory: bugE-hard

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions