Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64 call abi does not zeroext (and one cannot assume it does so) #97800

Merged
merged 10 commits into from
Sep 16, 2022
Merged

Aarch64 call abi does not zeroext (and one cannot assume it does so) #97800

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7913b85
unit tests that inspect LLVM output directly. This relies on a human …
pnkfelix Jun 16, 2022
b2777ab
End-to-end regression test for 97463.
pnkfelix Jun 6, 2022
8ae5a55
fix issue 97463 using change suggested by nbdd0121.
pnkfelix Jun 6, 2022
dfdb017
experiment: trying to encode the end-to-end test as a ui test via rus…
pnkfelix Jun 30, 2022
99c0f91
fix typo, thanks wesley
pnkfelix Aug 4, 2022
9bf3d5a
Ignore test on wasm
wesleywiser Aug 5, 2022
59cc718
Update codegen tests to accommodate the potential presence/absence of…
pnkfelix Aug 19, 2022
ed9b12d
rustdoc doesn't like bare urls
wesleywiser Aug 22, 2022
d73614a
Do not run run-make test tied to unix-style `$(CC)` on MSVC host.
pnkfelix Sep 16, 2022
a2de75a
fix typo in comment noted by bjorn3.
pnkfelix Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo, thanks wesley 
Co-authored-by: Wesley Wiser <wwiser@gmail.com>
  • Loading branch information
@pnkfelix @wesleywiser
pnkfelix and wesleywiser authored Aug 4, 2022
commit 99c0f91a4dd235824c353a11a2e75c462c9bbb74
2 changes: 1 addition & 1 deletion src/test/run-make-fulldeps/issue-97463-abi-param-passing/param_passing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ fn main() {
let value: u16 = unsafe { c_read_value(r1 as u32, r2 as u32, r3 as u32) };

// NOTE: as an example of the sensitivity of this test to optimization choices,
// uncommenting this block of code makes the bug go away on pnkfeix's machine.
// uncommenting this block of code makes the bug go away on pnkfelix's machine.
// (But observing via `dbg!` doesn't hide the bug. At least sometimes.)
/*
println!("{}", value);
Expand Down