Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain why CTFE/Miri perform truncation on shift offset #91162

Merged
merged 2 commits into from
Nov 25, 2021
Merged

explain why CTFE/Miri perform truncation on shift offset #91162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94c9c22
explain why CTFE/Miri perform truncation on shift offset
RalfJung Nov 23, 2021
5f6ccf6
document BinOp behavior quirks in the corresponding enum
RalfJung Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
document BinOp behavior quirks in the corresponding enum
  • Loading branch information
@RalfJung
RalfJung committed Nov 24, 2021
commit 5f6ccf61218fb98c2aa2cff0af83557d7ccaa5fd
8 changes: 8 additions & 0 deletions compiler/rustc_middle/src/mir/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2246,8 +2246,12 @@ pub enum BinOp {
/// The `*` operator (multiplication)
Mul,
/// The `/` operator (division)
///
/// Division by zero is UB.
Div,
/// The `%` operator (modulus)
///
/// Using zero as the modulus (second operand) is UB.
Rem,
/// The `^` operator (bitwise xor)
BitXor,
Expand All @@ -2256,8 +2260,12 @@ pub enum BinOp {
/// The `|` operator (bitwise or)
BitOr,
/// The `<<` operator (shift left)
///
/// The offset is truncated to the size of the first operand before shifting.
Shl,
/// The `>>` operator (shift right)
///
/// The offset is truncated to the size of the first operand before shifting.
Shr,
/// The `==` operator (equality)
Eq,
Expand Down