Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe binder support in rustdoc #134857

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Unsafe binder support in rustdoc #134857

merged 1 commit into from
Dec 31, 2024
+68 −12

Conversation

compiler-errors
Copy link
Member

Adds rustdoc support for unsafe binder types: unsafe<'a> Foo<'a>. Doesn't add json support yet.

Tracking:

@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 28, 2024
camelid
camelid approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comments addressed

src/librustdoc/html/format.rs Outdated Show resolved Hide resolved
tests/rustdoc/unsafe-binder.rs Show resolved Hide resolved
@camelid camelid assigned camelid and unassigned fmease Dec 29, 2024
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2024
@compiler-errors
Copy link
Member Author

@bors r=camelid rollup

@bors
Copy link
Contributor

bors commented Dec 31, 2024

📌 Commit 54f1a12 has been approved by camelid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2024
@compiler-errors
Copy link
Member Author

Whoops forgot to push

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 31, 2024
@compiler-errors
Copy link
Member Author

@bors r=camelid

@bors
Copy link
Contributor

bors commented Dec 31, 2024

📌 Commit aac741a has been approved by camelid

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2024
@jhpratt jhpratt mentioned this pull request Dec 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2024
@bors
Auto merge of rust-lang#134959 - jhpratt:rollup-vxt40of, r=jhpratt
aea4e43 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#134291 (Use python built in type annotations in LLDB visualizer scripts)
 - rust-lang#134857 (Unsafe binder support in rustdoc)
 - rust-lang#134957 (chore: fix some typos)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3785bc2 into rust-lang:master Dec 31, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2024
@rust-timer
Unrolled build for rust-lang#134857
78f2271 
Rollup merge of rust-lang#134857 - compiler-errors:rustdoc-unsafe-binders, r=camelid

Unsafe binder support in rustdoc

Adds rustdoc support for unsafe binder types: `unsafe<'a> Foo<'a>`. Doesn't add json support yet.

Tracking:
* rust-lang#130516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid approved these changes

Assignees

@camelid camelid

Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @bors @camelid @fmease