Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ./x clippy ci #132649

Merged
merged 4 commits into from
Nov 14, 2024
Merged

add ./x clippy ci #132649

merged 4 commits into from
Nov 14, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Nov 5, 2024 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 5, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 5, 2024

r? bootstrap (a bit busy with other compiletest stuff)

@rustbot rustbot assigned Mark-Simulacrum and unassigned jieyouxu Nov 5, 2024
@onur-ozkan
Copy link
Member

r? onur-ozkan

@rustbot rustbot assigned onur-ozkan and unassigned Mark-Simulacrum Nov 5, 2024
@klensy
Copy link
Contributor Author

klensy commented Nov 5, 2024

Weird: passes CI, but locally breaks on bootstrap warnings.

@onur-ozkan
Copy link
Member

Weird: passes CI, but locally breaks on bootstrap warnings.

It will probably fail on llvm-18 runner.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@klensy
Copy link
Contributor Author

klensy commented Nov 5, 2024

Eh? Why bootstrap tests fails in x86_64-gnu-llvm-18 55min, but not in mingw-check 35min.

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@klensy
Copy link
Contributor Author

klensy commented Nov 5, 2024 •
edited
Loading

Weird: passes CI, but locally breaks on bootstrap warnings.

It will probably fail on llvm-18 runner.

Actually, python x.py clippy bootstrap -Dwarnings fails on master too (locally), but passes in CI.

@klensy
Copy link
Contributor Author

klensy commented Nov 5, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2024
@bors
Copy link
Contributor

bors commented Nov 11, 2024

☔ The latest upstream changes (presumably #132902) made this pull request unmergeable. Please resolve the merge conflicts.

@klensy
Copy link
Contributor Author

klensy commented Nov 12, 2024

Okay, thing is that x.py clippy bootstrap didn't run on windows CI, so it missed some cfg(windows) things that emitted warnings.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2024
@bors
Copy link
Contributor

bors commented Nov 12, 2024

☔ The latest upstream changes (presumably #132954) made this pull request unmergeable. Please resolve the merge conflicts.

onur-ozkan
onur-ozkan approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the rebase

@onur-ozkan onur-ozkan removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2024
@onur-ozkan onur-ozkan added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 13, 2024
@klensy
Copy link
Contributor Author

klensy commented Nov 14, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 14, 2024
@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2024

📌 Commit cdd948c has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 14, 2024
@GuillaumeGomez
Rollup merge of rust-lang#132649 - klensy:pa-clippy-ci, r=onur-ozkan
853ed24 
add ./x clippy ci

This is rebase of rust-lang#126321

also https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/enable.20more.20clippy.20lints.20for.20compiler.20.28and.5Cor.20std.29 for context
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@bors
Auto merge of rust-lang#133039 - GuillaumeGomez:rollup-i223onq, r=Gui…
90ab8ea 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#132172 (borrowck diagnostics: suggest borrowing function inputs in generic positions)
 - rust-lang#132649 (add ./x clippy ci)
 - rust-lang#133005 (rustdoc: use a trie for name-based search)
 - rust-lang#133034 (update download-rustc comments and default)
 - rust-lang#133036 (add myself into `users_on_vacation` on triagebot)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1a1efaf into rust-lang:master Nov 14, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
@rust-timer
Unrolled build for rust-lang#132649
6e108d5 
Rollup merge of rust-lang#132649 - klensy:pa-clippy-ci, r=onur-ozkan

add ./x clippy ci

This is rebase of rust-lang#126321

also https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/enable.20more.20clippy.20lints.20for.20compiler.20.28and.5Cor.20std.29 for context
@pietroalbini pietroalbini mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@onur-ozkan onur-ozkan

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
8 participants
@klensy @rustbot @jieyouxu @onur-ozkan @rust-log-analyzer @bors @Mark-Simulacrum @pietroalbini