std: Improve docs for atomics. Fix two bugs #12954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //! | ||
| //! let spinlock_clone = spinlock.clone(); | ||
| //! spawn(proc() { | ||
| //! spinlock_clone.get().store(0, SeqCst); |
There was a problem hiding this comment.
If we're writing "ideal code", perhaps this could elide the get() because of #12900?
There was a problem hiding this comment.
(similar elisions could happen in the below examples)
|
Nice examples! Also good catch on those two bugs |
This adds lots of docs to the atomics module. Two of the examples are using the future atomics API and are ignored temporarily. I discovered a bug in the way AtomicBool's fetch_nand method is implemented and fixed it by using the correct value for `true`. I also fixed the implementation of AcqRel fences (it was only doing a release barrier), and made a "relaxed" fence a failure.
|
All points addressed. |
bors
added a commit
that referenced
this pull request
Mar 19, 2014
This adds lots of docs to the atomics module. Two of the examples are using the future atomics API (relying on `Share`) and are ignored temporarily. I discovered a bug in the way AtomicBool's fetch_nand method is implemented and fixed it by using the correct value for `true`. I also fixed the implementation of AcqRel fences (it was only doing a release barrier), and made a "relaxed" fence a failure.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 25, 2024
…cientific notation fixes: rust-lang#12954 changelog: fix [`excessive_precision`] suggestions on float literal written in scientific notation
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 25, 2024
fix [`excessive_precision`] suggestions on floats written in scientific notation fixes rust-lang#12954 changelog: fix [`excessive_precision`] suggestions on float literal written in scientific notation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds lots of docs to the atomics module. Two of the examples
are using the future atomics API (relying on
Share) and are ignored temporarily.I discovered a bug in the way AtomicBool's fetch_nand method is
implemented and fixed it by using the correct value for
true.I also fixed the implementation of AcqRel fences (it was only doing
a release barrier), and made a "relaxed" fence a failure.