Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #129359

Merged
merged 27 commits into from
Aug 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
78caecf
Special case DUMMY_SP to emit line 0/column 0 locations on DWARF plat…
khuey Aug 4, 2024
e587855
Use Span::is_dummy().
khuey Aug 4, 2024
5dc4a19
Fix warning.
khuey Aug 4, 2024
1350a65
Remove a Redundant Conditional Check
veera-sivarajan Aug 8, 2024
c8ae02f
CFI: Erase regions when projecting ADT to its transparent non-1zst field
compiler-errors Aug 17, 2024
25964b5
Reword the "unreachable pattern" explanations
Nadrieril Aug 19, 2024
efb28bd
Add a note with a link to explain empty types
Nadrieril Aug 19, 2024
36eced4
Cap the number of patterns pointed to by the lint
Nadrieril Aug 19, 2024
3c735a0
Add a test.
khuey Aug 20, 2024
4e9725c
Add a comment.
khuey Aug 20, 2024
f30392a
Move the "matches no value" note to be a span label
Nadrieril Aug 20, 2024
e424e7f
Avoid extra `cast()`s after `CStr::as_ptr()`
cuviper Aug 20, 2024
0f5c6ea
Make `ArgAbi::make_indirect_force` more specific
beetrees Aug 21, 2024
25ff9b6
Use bool in favor of Option<()> for diagnostics
compiler-errors Aug 21, 2024
0b2525c
Simplify some redundant field names
compiler-errors Aug 21, 2024
9010708
fix comment on PlaceMention semantics
RalfJung Aug 21, 2024
123bb58
Fix stability attribute of `impl !Error for &str`
tbu- Aug 20, 2024
dea325e
Rollup merge of #128627 - khuey:DUMMY_SP-line-no, r=nnethercote
matthiaskrgr Aug 21, 2024
48c9864
Rollup merge of #128843 - veera-sivarajan:small-cleanup, r=davidtwco
matthiaskrgr Aug 21, 2024
7da4b2d
Rollup merge of #129179 - compiler-errors:cfi-erase-transparent, r=da…
matthiaskrgr Aug 21, 2024
9bb17d3
Rollup merge of #129281 - Nadrieril:tweak-unreachable-lint-wording, r…
matthiaskrgr Aug 21, 2024
349f299
Rollup merge of #129312 - tbu-:pr_str_not_impl_error, r=Noratrieb
matthiaskrgr Aug 21, 2024
e961d6b
Rollup merge of #129332 - cuviper:cstr-cast, r=compiler-errors
matthiaskrgr Aug 21, 2024
be80216
Rollup merge of #129339 - beetrees:make-indirect-from-ignore, r=RalfJung
matthiaskrgr Aug 21, 2024
937a18d
Rollup merge of #129344 - compiler-errors:less-option-unit-diagnostic…
matthiaskrgr Aug 21, 2024
4137f3b
Rollup merge of #129345 - compiler-errors:scratch4, r=jieyouxu
matthiaskrgr Aug 21, 2024
9fd2832
Rollup merge of #129355 - RalfJung:PlaceMention, r=compiler-errors
matthiaskrgr Aug 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Span::is_dummy().
khuey committed Aug 4, 2024
commit e5878555387e4ced52b3dd6c5f6a04a5f47eeed7
2 changes: 1 addition & 1 deletion compiler/rustc_codegen_llvm/src/debuginfo/mod.rs
Original file line number Diff line number Diff line change
@@ -570,7 +570,7 @@ impl<'ll, 'tcx> DebugInfoMethods<'tcx> for CodegenCx<'ll, 'tcx> {
inlined_at: Option<&'ll DILocation>,
span: Span,
) -> &'ll DILocation {
let (line, col) = if span == DUMMY_SP && !self.sess().target.is_like_msvc {
let (line, col) = if span.is_dummy() && !self.sess().target.is_like_msvc {
(0, 0)
} else {
let DebugLoc { line, col, .. } = self.lookup_debug_loc(span.lo());
Loading
Oops, something went wrong.