Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isqrt to NonZero<uN> #126199

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Add isqrt to NonZero<uN> #126199

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaaed00
add `NonZero<uN>::isqrt`
ivan-shrimp Jul 19, 2024
90bba8b
improve safety comment
ivan-shrimp Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve safety comment
  • Loading branch information
@ivan-shrimp
ivan-shrimp committed Jul 19, 2024
commit 90bba8beb5cba6cbd0ff0fc92ed0a8b8ef537f8c
2 changes: 1 addition & 1 deletion library/core/src/num/nonzero.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ macro_rules! nonzero_integer_signedness_dependent_methods {
// Inform the optimizer about it.
unsafe { hint::assert_unchecked(res < 1 << (Self::BITS / 2)) };

// SAFETY: The result is positive.
// SAFETY: The square root of an integer >= 1 is always >= 1.
unsafe { Self::new_unchecked(res) }
}
};
Expand Down
Loading