Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #125624

Closed
wants to merge 17 commits into from
Closed

Rollup of 5 pull requests #125624

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c8b0e5b
The number of tests does not depend on the architecture's pointer width
tbu- May 20, 2024
90fec5a
Add `copy_dir_all` and `recursive_diff` functions to `run-make-support`
GuillaumeGomez May 25, 2024
1551fd1
Add file path in case it cannot be read in `Diff::actual_file`
GuillaumeGomez May 25, 2024
f0ab814
Add `Rustdoc::output_format`
GuillaumeGomez May 25, 2024
bdf3864
Migrate `run-make/rustdoc-verify-output-files` to `rmake.rs`
GuillaumeGomez May 25, 2024
7d24f87
MIR validation: ensure that downcast projection is followed by field …
RalfJung May 27, 2024
b3ee911
Use `rmake` for `windows-` run-make tests
ChrisDenton May 27, 2024
57e68b6
Remove Makefiles from allowed_run_make_makefiles
ChrisDenton May 27, 2024
e081170
Add linker option to run-make-support
ChrisDenton May 27, 2024
ad5dce5
Move run-make windows_subsystem tests to ui tests
ChrisDenton May 27, 2024
e5d1003
crashes: increment the number of tracked ones
matthiaskrgr May 25, 2024
894386a
remove fixed crashes, add fixed crashes to tests, add new cashed foun…
matthiaskrgr May 27, 2024
569f510
Rollup merge of #125339 - tbu-:pr_tidy_ui_tests_u32, r=clubby789
matthiaskrgr May 27, 2024
22e8279
Rollup merge of #125539 - matthiaskrgr:cräsh, r=jieyouxu
matthiaskrgr May 27, 2024
69308e9
Rollup merge of #125542 - GuillaumeGomez:migrate-rustdoc-verify-outpu…
matthiaskrgr May 27, 2024
834914c
Rollup merge of #125613 - ChrisDenton:windows-recipie, r=jieyouxu
matthiaskrgr May 27, 2024
a3d4b5f
Rollup merge of #125616 - RalfJung:mir-validate-downcast-projection, …
matthiaskrgr May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/tools/tidy/src/ui_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ use std::path::{Path, PathBuf};
// should all be 1000 or lower. Limits significantly smaller than 1000 are also
// desirable, because large numbers of files are unwieldy in general. See issue
// #73494.
const ENTRY_LIMIT: usize = 900;
const ENTRY_LIMIT: u32 = 900;
// FIXME: The following limits should be reduced eventually.

const ISSUES_ENTRY_LIMIT: usize = 1676;
const ISSUES_ENTRY_LIMIT: u32 = 1676;

const EXPECTED_TEST_FILE_EXTENSIONS: &[&str] = &[
"rs", // test source files
Expand Down Expand Up @@ -53,7 +53,7 @@ const EXTENSION_EXCEPTION_PATHS: &[&str] = &[
];

fn check_entries(tests_path: &Path, bad: &mut bool) {
let mut directories: HashMap<PathBuf, usize> = HashMap::new();
let mut directories: HashMap<PathBuf, u32> = HashMap::new();

for dir in Walk::new(&tests_path.join("ui")) {
if let Ok(entry) = dir {
Expand All @@ -62,7 +62,7 @@ fn check_entries(tests_path: &Path, bad: &mut bool) {
}
}

let (mut max, mut max_issues) = (0usize, 0usize);
let (mut max, mut max_issues) = (0, 0);
for (dir_path, count) in directories {
let is_issues_dir = tests_path.join("ui/issues") == dir_path;
let (limit, maxcnt) = if is_issues_dir {
Expand Down