Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] bootstrap with next solver enabled #124812

Closed
wants to merge 18 commits into from
Closed

[DO NOT MERGE] bootstrap with next solver enabled #124812

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d248a06
avoid non-defining uses in defining scope
lcnr May 22, 2024
26ef6e1
update winnowing
lcnr May 22, 2024
ba641d2
add debug_assert to alias-relate
lcnr May 21, 2024
48af4e6
change selection test to run-pass
lcnr May 21, 2024
4df2802
refactor analyse visitor to instantiate states in order
lcnr May 21, 2024
a21e2fb
eagerly normalize when adding goals
lcnr May 21, 2024
87123f6
add a normalizes-to fast path
lcnr May 20, 2024
46fa6ae
add fixme :(
lcnr May 21, 2024
45046f9
alias-relate: add fast reject optimization
lcnr May 21, 2024
c147f84
omg wtf
compiler-errors May 2, 2024
4ab9f49
alias-relate: add fast reject optimization
lcnr May 21, 2024
72459fd
drop region constraints for ambiguous goals
lcnr May 22, 2024
8bcd046
add a regression test
lcnr May 22, 2024
25140e5
increase recursion limit
lcnr May 24, 2024
d96714b
itertools, use git repo
lcnr May 24, 2024
ced92ab
enable new solver everywhere
lcnr May 24, 2024
bb557f5
Revert "core: use `Copy` in TAIT to fix clippy lint"
lcnr May 24, 2024
18a413a
Revert "core: actually use TAIT instead of emulating it"
lcnr May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add fixme :(
  • Loading branch information
@lcnr
lcnr committed May 24, 2024
commit 46fa6aefd1f29ddccb7d258b4dcb6998f33d2f01
8 changes: 6 additions & 2 deletions compiler/rustc_trait_selection/src/solve/normalizes_to/fast_reject.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ pub(super) fn is_rigid_alias<'tcx>(
// which is non-trivial. We may be forced to handle this case
// in the future.
alias.self_ty().is_placeholder()
&& no_blanket_impls(tcx, alias.trait_def_id(tcx))
&& no_applicable_blanket_impls(tcx, alias.trait_def_id(tcx))
&& !may_normalize_via_env(param_env, alias)
}

// FIXME: This could check whether the blanket impl has any where-bounds
// which definitely don't hold. Doing so is quite annoying, both just in
// general, but we also have to be careful about builtin blanket impls,
// e.g. `DiscriminantKind`.
#[instrument(level = "trace", skip(tcx), ret)]
fn no_blanket_impls<'tcx>(tcx: TyCtxt<'tcx>, trait_def_id: DefId) -> bool {
fn no_applicable_blanket_impls<'tcx>(tcx: TyCtxt<'tcx>, trait_def_id: DefId) -> bool {
// FIXME(ptr_metadata): There's currently a builtin impl for `Pointee` which
// applies for all `T` as long as `T: Sized` holds. THis impl should
// get removed in favor of `Pointee` being a super trait of `Sized`.
Expand Down