Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVPTX: Allow PassMode::Direct for ptx kernels for now #117247

Merged
merged 3 commits into from
Oct 27, 2023
Merged

NVPTX: Allow PassMode::Direct for ptx kernels for now #117247

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84c9c4a
NVPTX: Allow PassMode::Direct for ptx kernels for now
kjetilkjeka Oct 26, 2023
4d33876
Documentation and error message improvements related to PassMode::Dir…
kjetilkjeka Oct 26, 2023
bb45c81
Link to correct issue in PassMode::Direct ptx-kernel exception
Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion compiler/rustc_codegen_llvm/src/abi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,13 @@ impl<'ll, 'tcx> FnAbiLlvmExt<'ll, 'tcx> for FnAbi<'tcx, Ty<'tcx>> {
// currently use this mode so we have to allow it -- but we absolutely
// shouldn't let any more targets do that.
// (Also see <https://github.com/rust-lang/rust/issues/115666>.)
//
// The unstable api `PtxKernel` also uses Direct for now.
kjetilkjeka marked this conversation as resolved.
Show resolved Hide resolved
// It needs to switch to something else before stabilization can happen.
// (Tracking issue abi_ptx: https://github.com/rust-lang/rust/issues/38788)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue specifically for "nvptx uses Direct for Aggregates", and link that from here and from #38788?

Copy link
Contributor Author

@kjetilkjeka kjetilkjeka Oct 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is created and linked to in code comments.

I updated my suggestion post with the new link but I do not have the permissions to update the tracking issue itself. That means someone else will have to copy over the correct link if we want it in the "head post" of the tracking issue.

I also see that @workingjubilee copied my suggestion to updated text into the tracking issue in #38788 (Thanks!), but that was still with the old link.

assert!(
matches!(&*cx.tcx.sess.target.arch, "wasm32" | "wasm64"),
matches!(&*cx.tcx.sess.target.arch, "wasm32" | "wasm64")
|| self.conv == Conv::PtxKernel,
"`PassMode::Direct` for aggregates only allowed on wasm targets\nProblematic type: {:#?}",
kjetilkjeka marked this conversation as resolved.
Show resolved Hide resolved
arg.layout,
);
Expand Down
Loading